[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add qemu_vga.ndrv to build/pc-bios folder
From: |
Laurent Vivier |
Subject: |
Re: [PATCH] Add qemu_vga.ndrv to build/pc-bios folder |
Date: |
Wed, 15 Sep 2021 16:02:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
Le 31/08/2021 à 22:52, Programmingkid a écrit :
>
>
>> On Aug 31, 2021, at 4:33 PM, Mark Cave-Ayland
>> <mark.cave-ayland@ilande.co.uk> wrote:
>>
>> On 31/08/2021 17:50, John Arbuckle wrote:
>>
>>> Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios
>>> folder. This makes all video resolution choices disappear from a PowerPC
>>> Mac OS guest. This patch has the qemu_vga.ndrv file copied into the
>>> build/pc-bios folder giving users back their video resolution choices.
>>> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>>> ---
>>> configure | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>> diff --git a/configure b/configure
>>> index 9a79a004d7..281577e46f 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -5056,7 +5056,9 @@ for bios_file in \
>>> $source_path/pc-bios/openbios-* \
>>> $source_path/pc-bios/u-boot.* \
>>> $source_path/pc-bios/edk2-*.fd.bz2 \
>>> - $source_path/pc-bios/palcode-*
>>> + $source_path/pc-bios/palcode-* \
>>> + $source_path/pc-bios/qemu_vga.ndrv
>>> +
>>> do
>>> LINKS="$LINKS pc-bios/$(basename $bios_file)"
>>> done
>>
>> I think the patch looks correct, however the commit message and subject
>> aren't quite right. How about something like:
>>
>> [PATCH] configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree
>>
>> Ensure that a link to pc-bios/qemu_vga.ndrv is added to the build tree,
>> otherwise the optional MacOS client driver will not be loaded by OpenBIOS
>> when launching QEMU directly from the build directory.
>>
>>
>> ATB,
>>
>> Mark.
>
> Ok. I will create a new patch with these changes.
>
Applied to my trivial-patches branch with Mark's commit message rewording and
Peter's R-b.
Thanks,
Laurent