qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus


From: Thomas Huth
Subject: Re: [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus
Date: Wed, 15 Sep 2021 16:10:49 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 15/09/2021 14.54, Daniel P. Berrangé wrote:
A typo meant the substitution would not work, and the placeholder in the
target file didn't even exist.

The result was that tests were never run on the FreeBSD and macOS jobs,
only a basic build.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
  .gitlab-ci.d/cirrus.yml       | 2 +-
  .gitlab-ci.d/cirrus/build.yml | 1 +
  2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml
index 675db69622..e7b25e7427 100644
--- a/.gitlab-ci.d/cirrus.yml
+++ b/.gitlab-ci.d/cirrus.yml
@@ -35,7 +35,7 @@
            -e "s|[@]PIP3@|$PIP3|g"
            -e "s|[@]PYPI_PKGS@|$PYPI_PKGS|g"
            -e "s|[@]CONFIGURE_ARGS@|$CONFIGURE_ARGS|g"
-          -e "s|[@]TEST_TARGETSS@|$TEST_TARGETSS|g"
+          -e "s|[@]TEST_TARGETS@|$TEST_TARGETS|g"

Ooops, missed that in the review :-/

Acked-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]