[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/6] qxl: fix pre-save logic
From: |
Gerd Hoffmann |
Subject: |
[PULL 1/6] qxl: fix pre-save logic |
Date: |
Thu, 16 Sep 2021 07:56:18 +0200 |
Oops. Logic is backwards.
Fixes: 39b8a183e2f3 ("qxl: remove assert in qxl_pre_save.")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/610
Resolves: https://bugzilla.redhat.com//show_bug.cgi?id=2002907
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210910094203.3582378-1-kraxel@redhat.com>
---
hw/display/qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 43482d4364ba..29c80b4289b7 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -2252,7 +2252,7 @@ static int qxl_pre_save(void *opaque)
} else {
d->last_release_offset = (uint8_t *)d->last_release - ram_start;
}
- if (d->last_release_offset < d->vga.vram_size) {
+ if (d->last_release_offset >= d->vga.vram_size) {
return 1;
}
--
2.31.1
- [PULL 0/6] Vga 20210916 patches, Gerd Hoffmann, 2021/09/16
- [PULL 1/6] qxl: fix pre-save logic,
Gerd Hoffmann <=
- [PULL 2/6] ui/gtk: Create a common release_dmabuf helper, Gerd Hoffmann, 2021/09/16
- [PULL 3/6] ui/egl: Add egl helpers to help with synchronization, Gerd Hoffmann, 2021/09/16
- [PULL 6/6] virtio-gpu: Add gl_flushed callback, Gerd Hoffmann, 2021/09/16
- [PULL 4/6] ui: Create sync objects and fences only for blobs, Gerd Hoffmann, 2021/09/16
- [PULL 5/6] ui/gtk-egl: Wait for the draw signal for dmabuf blobs, Gerd Hoffmann, 2021/09/16
- Re: [PULL 0/6] Vga 20210916 patches, Peter Maydell, 2021/09/16