On 17.09.21 07:40, John Snow wrote:
> This allows 'Greeting' to be subclass of 'Message'. We need the adapter
> classes to avoid some typing problems that occur if we try to put too
> much into the 'Model' class itself; the exact details of why are left as
> an exercise to the reader.
>
> Why bother? This makes 'Greeting' ⊆ 'Message', which is taxonomically
> true; but the real motivation is to be able to inherit and abuse all of
> the Mapping dunders so that we can call dict(greeting) or
> bytes(greeting), for example.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/aqmp/models.py | 67 ++++++++++++++++++++++++++++----------
> 1 file changed, 50 insertions(+), 17 deletions(-)
(I feel like this is a bit much outside of my scope, so this’ll have to
do without my R-b.)
It's a patch I like the least, too. I shouldn't have included it here in this series. It needs more time in the oven and it should be included ... somewhere else.
Sorry about this one.