|
From: | WANG Xuerui |
Subject: | Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts |
Date: | Tue, 21 Sep 2021 22:07:07 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0a1 |
Hi Richard, On 9/21/21 21:30, Richard Henderson wrote:
I just dug deeper into this while waiting for compilations; indeed the cpu variable must be "loongarch64" but ARCH could be just "loongarch". The $cpu is shoved directly into the meson cross file as CPU family name, for which only "loongarch64" is valid [1]. I'll keep probing for __loongarch64 but just transform the ARCH value.On 9/20/21 11:02 PM, WANG Xuerui wrote:So should I drop the explicit probing for __loongarch64, instead just probe for __loongarch__ and later #error out the non-__loongarch64 cases individually?I'm ok with checking the __loongarch64 define, but I thing ARCH=loongarch is sufficient. That name will apply to linux-user/host/$ARCH/ and tcg/$ARCH/.
[1]: https://mesonbuild.com/Reference-tables.html#cpu-families
[Prev in Thread] | Current Thread | [Next in Thread] |