Re: [PATCH v3 03/16] iotests/migrate-bitmaps-postcopy-test: declare instance variables

[John Snow]

On Fri, Sep 17, 2021 at 4:37 AM Hanna Reitz <hreitz@redhat.com> wrote:

On 16.09.21 06:09, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> index 00ebb5c251..9c00ae61c8 100755
> --- a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> +++ b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> @@ -115,6 +115,9 @@ class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
>           self.vm_a_events = []
>           self.vm_b_events = []
>   
> +        self.discards1_sha256: str
> +        self.all_discards_sha256: str
> +
>       def start_postcopy(self):
>           """ Run migration until RESUME event on target. Return this event. """
>           for i in range(nb_bitmaps):

Isn’t this obsolete after e2ad17a62d9da45fbcddc3faa3d6ced519a9453a?

Hanna

Yes, my apologies.

--js