[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/30] tcg/loongarch64: Add generated instruction opcodes
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 04/30] tcg/loongarch64: Add generated instruction opcodes and encoding helpers |
|
Date: |
Wed, 22 Sep 2021 21:32:05 +0200 |
On Wed, Sep 22, 2021 at 8:51 PM WANG Xuerui <i.qemu@xen0n.name> wrote:
>
> Hi Philippe,
>
> On 9/23/21 02:37, Philippe Mathieu-Daudé wrote:
> > On 9/22/21 20:09, WANG Xuerui wrote:
> >> <snip>
> >
> > The generated code ...
> >
> >> <snip>
> >
> > ... ends here, right? ...
> >
> >> <snip>
> >
> > ... or are these helpers also generated?
>
> I actively hate writing these by hand, so of course the whole file is
> auto-generated with some quick Go scripting in that repo. Even including
> auto-formatting with clang-format so I could directly pipe the output
> into this file...
Awesome then :) Maybe add /* End of generated code */ comment at the
end to make it obvious?
- Re: [PATCH v3 03/30] tcg/loongarch64: Add the tcg-target.h file, (continued)
[PATCH v3 01/30] elf: Add machine type value for LoongArch, WANG Xuerui, 2021/09/22
[PATCH v3 04/30] tcg/loongarch64: Add generated instruction opcodes and encoding helpers, WANG Xuerui, 2021/09/22
[PATCH v3 08/30] tcg/loongarch64: Implement the memory barrier op, WANG Xuerui, 2021/09/22
[PATCH v3 06/30] tcg/loongarch64: Define the operand constraints, WANG Xuerui, 2021/09/22
[PATCH v3 09/30] tcg/loongarch64: Implement tcg_out_mov and tcg_out_movi, WANG Xuerui, 2021/09/22