|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH v5 17/20] nubus-bridge: make slot_available_mask a qdev property |
Date: | Thu, 23 Sep 2021 11:52:12 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 9/23/21 11:13, Mark Cave-Ayland wrote:
This is to allow Macintosh machines to further specify which slots are available since the number of addressable slots may not match the number of physical slots present in the machine. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Reviewed-by: Laurent Vivier <laurent@vivier.eu> --- hw/nubus/nubus-bridge.c | 7 +++++++ 1 file changed, 7 insertions(+)
+static Property nubus_bridge_properties[] = { + DEFINE_PROP_UINT32("slot-available-mask", NubusBridge, + bus.slot_available_mask, 0xffff),
What about using DEFINE_PROP_UINT16() here and uint16_t in patch 04/20 "nubus: use bitmap to manage available slots"? Regardless: Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
+ DEFINE_PROP_END_OF_LIST() +};
[Prev in Thread] | Current Thread | [Next in Thread] |