[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 0/2] qapi: Move RTC_CHANGE back out of target schema
From: |
Peter Maydell |
Subject: |
[PATCH 0/2] qapi: Move RTC_CHANGE back out of target schema |
Date: |
Fri, 24 Sep 2021 15:01:40 +0100 |
This patchset moves RTC_CHANGE back to misc.json, effectively
reverting commit 183e4281a30962, which moved the RTC_CHANGE event to
the target schema. That change was an attempt to make the event
target-specific to improve introspection, but the event isn't really
target-specific: it's machine or device specific. Putting RTC_CHANGE
in the target schema with an ifdef list reduces maintainability (by
adding an if: list with a long list of targets that needs to be
manually updated as architectures are added or removed or as new
devices gain the RTC_CHANGE functionality) and increases compile time
(by preventing RTC devices which emit the event from being "compile
once" rather than "compile once per target", because
qapi-events-misc-target.h uses TARGET_* ifdefs, which are poisoned in
"compile once" files.)
Patch 2 fixes a minor documentation issue that I noticed while
I was doing this -- we didn't document that the units used in
the RTC_CHANGE event are seconds.
thanks
-- PMM
Peter Maydell (2):
qapi: Move RTC_CHANGE back out of target schema
qapi: Document the units for the offset argument to RTC_CHANGE
qapi/misc-target.json | 33 ---------------------------------
qapi/misc.json | 22 ++++++++++++++++++++++
hw/ppc/spapr_rtc.c | 2 +-
hw/rtc/mc146818rtc.c | 2 +-
4 files changed, 24 insertions(+), 35 deletions(-)
--
2.20.1
- [PATCH 0/2] qapi: Move RTC_CHANGE back out of target schema,
Peter Maydell <=