[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/11] qdev: Base object creation on QDict rather than QemuOp
From: |
Eric Blake |
Subject: |
Re: [PATCH 08/11] qdev: Base object creation on QDict rather than QemuOpts |
Date: |
Fri, 24 Sep 2021 13:53:37 -0500 |
User-agent: |
NeoMutt/20210205-773-8890a5 |
On Fri, Sep 24, 2021 at 11:04:24AM +0200, Kevin Wolf wrote:
> QDicts are both what QMP natively uses and what the keyval parser
> produces. Going through QemuOpts isn't useful for either one, so switch
> the main device creation function to QDicts. By sharing more code with
> the -object/object-add code path, we can even reduce the code size a
> bit.
>
> This commit doesn't remove the detour through QemuOpts from any code
> path yet, but it allows the following commits to do so.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> include/hw/qdev-core.h | 8 ++---
> hw/core/qdev.c | 5 ++--
> hw/net/virtio-net.c | 4 +--
> hw/vfio/pci.c | 4 +--
> softmmu/qdev-monitor.c | 67 +++++++++++++++++++-----------------------
> 5 files changed, 41 insertions(+), 47 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH 02/11] iotests/245: Fix type for iothread property, (continued)
- [PATCH 08/11] qdev: Base object creation on QDict rather than QemuOpts, Kevin Wolf, 2021/09/24
- Re: [PATCH 08/11] qdev: Base object creation on QDict rather than QemuOpts,
Eric Blake <=
- [PATCH 07/11] qemu-option: Allow deleting opts during qemu_opts_foreach(), Kevin Wolf, 2021/09/24
- [PATCH 06/11] qdev: Add Error parameter to qdev_set_id(), Kevin Wolf, 2021/09/24
- [PATCH 10/11] vl: Enable JSON syntax for -device, Kevin Wolf, 2021/09/24
- [PATCH 11/11] Deprecate stable non-JSON -device and -object, Kevin Wolf, 2021/09/24