[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 01/40] accel: Simplify qemu_init_vcpu()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v7 01/40] accel: Simplify qemu_init_vcpu() |
Date: |
Sat, 25 Sep 2021 16:50:39 +0200 |
cpus_register_accel() already checks for ops->create_vcpu_thread
being non-NULL, so it is pointless to re-check for it in
qemu_init_vcpu().
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
softmmu/cpus.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/softmmu/cpus.c b/softmmu/cpus.c
index 071085f840b..646326b24fd 100644
--- a/softmmu/cpus.c
+++ b/softmmu/cpus.c
@@ -604,7 +604,10 @@ void cpu_remove_sync(CPUState *cpu)
void cpus_register_accel(const AccelOpsClass *ops)
{
assert(ops != NULL);
- assert(ops->create_vcpu_thread != NULL); /* mandatory */
+
+ /* Mandatory non-NULL handlers */
+ assert(ops->create_vcpu_thread != NULL);
+
cpus_accel = ops;
}
@@ -626,7 +629,7 @@ void qemu_init_vcpu(CPUState *cpu)
}
/* accelerators all implement the AccelOpsClass */
- g_assert(cpus_accel != NULL && cpus_accel->create_vcpu_thread != NULL);
+ g_assert(cpus_accel != NULL);
cpus_accel->create_vcpu_thread(cpu);
while (!cpu->created) {
--
2.31.1
- [PATCH v7 00/40] accel: Move has_work() from CPUClass to AccelOpsClass, Philippe Mathieu-Daudé, 2021/09/25
- [PATCH v7 01/40] accel: Simplify qemu_init_vcpu(),
Philippe Mathieu-Daudé <=
- [PATCH v7 02/40] hw/core: Restrict cpu_has_work() to sysemu, Philippe Mathieu-Daudé, 2021/09/25
- [PATCH v7 03/40] hw/core: Un-inline cpu_has_work(), Philippe Mathieu-Daudé, 2021/09/25
- [PATCH v7 04/40] hw/core: Move cpu_common_has_work() to cpu_has_work(), Philippe Mathieu-Daudé, 2021/09/25
- [PATCH v7 05/40] accel: Introduce AccelOpsClass::has_work(), Philippe Mathieu-Daudé, 2021/09/25
- [PATCH v7 06/40] accel/kvm: Implement AccelOpsClass::has_work(), Philippe Mathieu-Daudé, 2021/09/25
- [PATCH v7 07/40] accel/whpx: Implement AccelOpsClass::has_work(), Philippe Mathieu-Daudé, 2021/09/25
- [PATCH v7 08/40] accel/hvf: Implement AccelOpsClass::has_work(), Philippe Mathieu-Daudé, 2021/09/25
- [PATCH v7 09/40] accel/xen: Implement AccelOpsClass::has_work(), Philippe Mathieu-Daudé, 2021/09/25
- [PATCH v7 10/40] accel/hax: Implement AccelOpsClass::has_work(), Philippe Mathieu-Daudé, 2021/09/25