|
From: | Richard Henderson |
Subject: | Re: [PATCH v7 12/40] accel/qtest: Implement AccelOpsClass::has_work() |
Date: | Sat, 25 Sep 2021 11:32:21 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 9/25/21 11:27 AM, Philippe Mathieu-Daudé wrote:
+static bool qtest_cpu_has_work(CPUState *cpu) +{ + g_assert_not_reached(); +}Sigh, this triggers: Running test qtest-i386/cpu-plug-test ** ERROR:../accel/qtest/qtest.c:52:qtest_cpu_has_work: code should not be reachedERROR qtest-i386/cpu-plug-test - Bail out! ERROR:../accel/qtest/qtest.c:52:qtest_cpu_has_work: code should not be reachedBroken pipe
Ha ha, yes. You beat me to the reply within minutes.
I suppose it is in my interest to 'return false' here and call it a day...
I *think* that's the right thing, but I could see maybe "true" also makes sense. I'll try and have a closer look.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |