[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 26/30] tcg/loongarch64: Implement tcg_target_init
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v6 26/30] tcg/loongarch64: Implement tcg_target_init |
Date: |
Sun, 26 Sep 2021 09:15:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 9/25/21 19:30, WANG Xuerui wrote:
> Signed-off-by: WANG Xuerui <git@xen0n.name>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/loongarch64/tcg-target.c.inc | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
> +static void tcg_target_init(TCGContext *s)
> +{
> + tcg_target_available_regs[TCG_TYPE_I32] = ALL_GENERAL_REGS;
> + tcg_target_available_regs[TCG_TYPE_I64] = ALL_GENERAL_REGS;
> +
> + tcg_target_call_clobber_regs = ALL_GENERAL_REGS;
If you plan to add support for vector registers later, I think it is
safer to start today with:
tcg_target_call_clobber_regs = -1ull;
> + tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S0);
> + tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S1);
> + tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S2);
> + tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S3);
> + tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S4);
> + tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S5);
> + tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S6);
> + tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S7);
> + tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S8);
> + tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S9);
> +
> + s->reserved_regs = 0;
> + tcg_regset_set_reg(s->reserved_regs, TCG_REG_ZERO);
> + tcg_regset_set_reg(s->reserved_regs, TCG_REG_TMP0);
> + tcg_regset_set_reg(s->reserved_regs, TCG_REG_TMP1);
> + tcg_regset_set_reg(s->reserved_regs, TCG_REG_TMP2);
> + tcg_regset_set_reg(s->reserved_regs, TCG_REG_SP);
> + tcg_regset_set_reg(s->reserved_regs, TCG_REG_TP);
> + tcg_regset_set_reg(s->reserved_regs, TCG_REG_RESERVED);
> +}
>
Conditional on using -1 to initialize:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v6 11/30] tcg/loongarch64: Implement sign-/zero-extension ops, (continued)
- [PATCH v6 11/30] tcg/loongarch64: Implement sign-/zero-extension ops, WANG Xuerui, 2021/09/25
- [PATCH v6 07/30] tcg/loongarch64: Implement necessary relocation operations, WANG Xuerui, 2021/09/25
- [PATCH v6 12/30] tcg/loongarch64: Implement not/and/or/xor/nor/andc/orc ops, WANG Xuerui, 2021/09/25
- [PATCH v6 09/30] tcg/loongarch64: Implement tcg_out_mov and tcg_out_movi, WANG Xuerui, 2021/09/25
- [PATCH v6 10/30] tcg/loongarch64: Implement goto_ptr, WANG Xuerui, 2021/09/25
- [PATCH v6 15/30] tcg/loongarch64: Implement clz/ctz ops, WANG Xuerui, 2021/09/25
- [PATCH v6 06/30] tcg/loongarch64: Define the operand constraints, WANG Xuerui, 2021/09/25
- [PATCH v6 26/30] tcg/loongarch64: Implement tcg_target_init, WANG Xuerui, 2021/09/25
- Re: [PATCH v6 26/30] tcg/loongarch64: Implement tcg_target_init,
Philippe Mathieu-Daudé <=
- [PATCH v6 21/30] tcg/loongarch64: Implement tcg_out_call, WANG Xuerui, 2021/09/25
- [PATCH v6 25/30] tcg/loongarch64: Implement exit_tb/goto_tb, WANG Xuerui, 2021/09/25
- [PATCH v6 24/30] tcg/loongarch64: Implement tcg_target_qemu_prologue, WANG Xuerui, 2021/09/25
- [PATCH v6 29/30] accel/tcg/user-exec: Implement CPU-specific signal handler for loongarch64 hosts, WANG Xuerui, 2021/09/25
- [PATCH v6 16/30] tcg/loongarch64: Implement shl/shr/sar/rotl/rotr ops, WANG Xuerui, 2021/09/25
- [PATCH v6 19/30] tcg/loongarch64: Implement br/brcond ops, WANG Xuerui, 2021/09/25
- [PATCH v6 14/30] tcg/loongarch64: Implement bswap{16,32,64} ops, WANG Xuerui, 2021/09/25