Re: Need to merge - QEMU patch for booting eMMC image for AST2600 machine

[Philippe Mathieu-Daudé]

Hi,

On 9/25/21 19:07, Shitalkumar Gandhi via wrote:
> Hi,
> 
> I am attaching a patch that will fix eMMC image booting on QEMU for
> AST2600 machine, without this patch it will be stuck after SPL saying,
> "booting from RAM".
> 
> Please review and merge, thanks.
> 
> Let me know in case of any concern.

Thanks for your patch.

Please look at how to submit patches here:
https://wiki.qemu.org/Contribute/SubmitAPatch#Submitting_your_Patches

> This patch has been added to boot eMMC image for AST2600 machine on
> QEMU.
>
> Run quemu as follows:
>
> ./qemu-system-arm -m 1G -M ast2600-evb -nographic -drive
> file=mmc-evb-ast2600.img,format=raw,if=sd,index=2

What is index=2?

Is this mmc-evb-ast2600.img image publicly available?

> Tested: Booted AST2600 eMMC image on QEMU.
> Suggested-by:  <venture@google.com>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
> Message-Id: <20210416162426.3217033-1-venture@google.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  hw/arm/aspeed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index ba5f1dc5af..6a890adb83 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -148,7 +148,7 @@ struct AspeedMachineState {
>          SCU_AST2400_HW_STRAP_BOOT_MODE(AST2400_SPI_BOOT))
>
>  /* AST2600 evb hardware value */
> -#define AST2600_EVB_HW_STRAP1 0x000000C0
> +#define AST2600_EVB_HW_STRAP1 (0x000000C0 |
AST26500_HW_STRAP_BOOT_SRC_EMMC)

IIUC you are not implementing any eMMC code, simply faking the
controller can support eMMC, but the card is used in SD mode?

I'm surprised your guest is happy and boot that. If so, then
what is the point of announcing eMMC is supported if not used?

Regards,

Phil.

>  #define AST2600_EVB_HW_STRAP2 0x00000003
>
>  /* Tacoma hardware value */
> --
>