[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] virtio-gpu: CONTEXT_INIT feature
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 1/1] virtio-gpu: CONTEXT_INIT feature |
Date: |
Tue, 28 Sep 2021 07:13:58 +0200 |
> @@ -212,6 +212,8 @@ virtio_gpu_base_get_features(VirtIODevice *vdev, uint64_t
> features,
> features |= (1 << VIRTIO_GPU_F_RESOURCE_BLOB);
> }
>
> + features |= (1 << VIRTIO_GPU_F_CONTEXT_INIT);
This needs a config option, simliar to the other features. It is a
guest-visible change so we must be able to turn it off for live
migration compatibility reasons. We also need a compat property to
turn it off by default for 6.1 + older machine types.
> + if (cc.context_init) {
> + virgl_renderer_context_create_with_flags(cc.hdr.ctx_id,
> + cc.context_init,
> + cc.nlen,
> + cc.debug_name);
This requires a minimum virglrenderer version I guess?
> --- a/include/standard-headers/linux/virtio_gpu.h
> +++ b/include/standard-headers/linux/virtio_gpu.h
Separate patch please.
Also use scripts/update-linux-headers.sh for this.
take care,
Gerd