[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 04/13] iotests/297: Don't rely on distro-specific linter binaries
From: |
John Snow |
Subject: |
[PATCH 04/13] iotests/297: Don't rely on distro-specific linter binaries |
Date: |
Mon, 4 Oct 2021 17:04:54 -0400 |
'pylint-3' is another Fedora-ism. Use "python3 -m pylint" or "python3 -m
mypy" to access these scripts instead. This style of invocation will
prefer the "correct" tool when run in a virtual environment.
Note that we still check for "pylint-3" before the test begins -- this
check is now "overly strict", but shouldn't cause anything that was
already running correctly to start failing.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
---
tests/qemu-iotests/297 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
index 15b54594c11..65b1e7058c2 100755
--- a/tests/qemu-iotests/297
+++ b/tests/qemu-iotests/297
@@ -71,14 +71,14 @@ def run_linters():
sys.stdout.flush()
env = os.environ.copy()
- subprocess.run(('pylint-3', *files),
+ subprocess.run(('python3', '-m', 'pylint', *files),
env=env, check=False)
print('=== mypy ===')
sys.stdout.flush()
env['MYPYPATH'] = env['PYTHONPATH']
- p = subprocess.run(('mypy', *files),
+ p = subprocess.run((('python3', '-m', 'mypy', *files),
env=env,
check=False,
stdout=subprocess.PIPE,
--
2.31.1
- Re: [PATCH 01/13] iotests/297: Move pylint config into pylintrc, (continued)
- [PATCH 03/13] iotests/297: Add get_files() function, John Snow, 2021/10/04
- [PATCH 05/13] iotests/297: Create main() function, John Snow, 2021/10/04
- [PATCH 07/13] iotests/297: Split run_linters apart into run_pylint and run_mypy, John Snow, 2021/10/04
- [PATCH 06/13] iotests/297: Separate environment setup from test execution, John Snow, 2021/10/04
- [PATCH 04/13] iotests/297: Don't rely on distro-specific linter binaries,
John Snow <=
- [PATCH 10/13] iotests/linters: Add entry point for linting via Python CI, John Snow, 2021/10/04
- [PATCH 08/13] iotests/297: refactor run_[mypy|pylint] as generic execution shim, John Snow, 2021/10/04
- [PATCH 09/13] iotests: split linters.py out from 297, John Snow, 2021/10/04
- [PATCH 13/13] iotests: [RFC] drop iotest 297, John Snow, 2021/10/04