[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v2 12/25] assertions for blockob.h global state API
From: |
Emanuele Giuseppe Esposito |
Subject: |
[RFC PATCH v2 12/25] assertions for blockob.h global state API |
Date: |
Tue, 5 Oct 2021 10:32:02 -0400 |
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
blockjob.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/blockjob.c b/blockjob.c
index 9878e255c6..3b224136c0 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -61,6 +61,7 @@ static bool is_block_job(Job *job)
BlockJob *block_job_next(BlockJob *bjob)
{
+ g_assert(qemu_in_main_thread());
Job *job = bjob ? &bjob->job : NULL;
do {
@@ -72,6 +73,7 @@ BlockJob *block_job_next(BlockJob *bjob)
BlockJob *block_job_get(const char *id)
{
+ g_assert(qemu_in_main_thread());
Job *job = job_get(id);
if (job && is_block_job(job)) {
@@ -185,6 +187,7 @@ static const BdrvChildClass child_job = {
void block_job_remove_all_bdrv(BlockJob *job)
{
+ g_assert(qemu_in_main_thread());
/*
* bdrv_root_unref_child() may reach child_job_[can_]set_aio_ctx(),
* which will also traverse job->nodes, so consume the list one by
@@ -207,6 +210,7 @@ void block_job_remove_all_bdrv(BlockJob *job)
bool block_job_has_bdrv(BlockJob *job, BlockDriverState *bs)
{
GSList *el;
+ g_assert(qemu_in_main_thread());
for (el = job->nodes; el; el = el->next) {
BdrvChild *c = el->data;
@@ -223,6 +227,7 @@ int block_job_add_bdrv(BlockJob *job, const char *name,
BlockDriverState *bs,
{
BdrvChild *c;
bool need_context_ops;
+ g_assert(qemu_in_main_thread());
bdrv_ref(bs);
@@ -272,6 +277,8 @@ bool block_job_set_speed(BlockJob *job, int64_t speed,
Error **errp)
const BlockJobDriver *drv = block_job_driver(job);
int64_t old_speed = job->speed;
+ g_assert(qemu_in_main_thread());
+
if (job_apply_verb(&job->job, JOB_VERB_SET_SPEED, errp) < 0) {
return false;
}
@@ -309,6 +316,8 @@ BlockJobInfo *block_job_query(BlockJob *job, Error **errp)
BlockJobInfo *info;
uint64_t progress_current, progress_total;
+ g_assert(qemu_in_main_thread());
+
if (block_job_is_internal(job)) {
error_setg(errp, "Cannot query QEMU internal jobs");
return NULL;
@@ -498,6 +507,7 @@ void *block_job_create(const char *job_id, const
BlockJobDriver *driver,
void block_job_iostatus_reset(BlockJob *job)
{
+ g_assert(qemu_in_main_thread());
if (job->iostatus == BLOCK_DEVICE_IO_STATUS_OK) {
return;
}
--
2.27.0
- Re: [RFC PATCH v2 06/25] include/block/block_int: split header into I/O and global state API, (continued)
- [RFC PATCH v2 10/25] assertions for blockjob_int.h, Emanuele Giuseppe Esposito, 2021/10/05
- [RFC PATCH v2 12/25] assertions for blockob.h global state API,
Emanuele Giuseppe Esposito <=
- [RFC PATCH v2 09/25] include/block/blockjob_int.h: split header into I/O and GS API, Emanuele Giuseppe Esposito, 2021/10/05
- [RFC PATCH v2 13/25] include/systemu/blockdev.h: global state API, Emanuele Giuseppe Esposito, 2021/10/05
- [RFC PATCH v2 11/25] include/block/blockjob.h: global state API, Emanuele Giuseppe Esposito, 2021/10/05