[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 04/13] job: Force-cancel jobs in a failed transaction
From: |
Hanna Reitz |
Subject: |
[PATCH v5 04/13] job: Force-cancel jobs in a failed transaction |
Date: |
Wed, 6 Oct 2021 17:19:31 +0200 |
When a transaction is aborted, no result matters, and so all jobs within
should be force-cancelled.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
job.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/job.c b/job.c
index 810e6a2065..e74d81928d 100644
--- a/job.c
+++ b/job.c
@@ -766,7 +766,12 @@ static void job_completed_txn_abort(Job *job)
if (other_job != job) {
ctx = other_job->aio_context;
aio_context_acquire(ctx);
- job_cancel_async(other_job, false);
+ /*
+ * This is a transaction: If one job failed, no result will matter.
+ * Therefore, pass force=true to terminate all other jobs as
quickly
+ * as possible.
+ */
+ job_cancel_async(other_job, true);
aio_context_release(ctx);
}
}
--
2.31.1
- [PATCH v5 00/13] mirror: Handle errors after READY cancel, Hanna Reitz, 2021/10/06
- [PATCH v5 01/13] job: Context changes in job_completed_txn_abort(), Hanna Reitz, 2021/10/06
- [PATCH v5 02/13] mirror: Keep s->synced on error, Hanna Reitz, 2021/10/06
- [PATCH v5 03/13] mirror: Drop s->synced, Hanna Reitz, 2021/10/06
- [PATCH v5 04/13] job: Force-cancel jobs in a failed transaction,
Hanna Reitz <=
- [PATCH v5 05/13] job: @force parameter for job_cancel_sync(), Hanna Reitz, 2021/10/06
- [PATCH v5 09/13] mirror: Use job_is_cancelled(), Hanna Reitz, 2021/10/06
- [PATCH v5 07/13] job: Do not soft-cancel after a job is done, Hanna Reitz, 2021/10/06
- [PATCH v5 06/13] jobs: Give Job.force_cancel more meaning, Hanna Reitz, 2021/10/06
- [PATCH v5 08/13] job: Add job_cancel_requested(), Hanna Reitz, 2021/10/06