[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/12] block-backend: convert blk_foo wrappers to use int64_t
From: |
Eric Blake |
Subject: |
Re: [PATCH 08/12] block-backend: convert blk_foo wrappers to use int64_t bytes parameter |
Date: |
Wed, 6 Oct 2021 11:29:49 -0500 |
User-agent: |
NeoMutt/20210205-815-1dd940 |
On Wed, Oct 06, 2021 at 03:17:14PM +0200, Vladimir Sementsov-Ogievskiy wrote:
> Convert blk_pdiscard, blk_pwrite_compressed, blk_pwrite_zeroes.
> These are just wrappers for functions with int64_t argument, so allow
> passing int64_t as well. Parameter type becomes wider so all callers
> should be OK with it.
>
> Note that requests exceeding INT_MAX are still restricted by
> blk_check_byte_request().
>
> Note also that we don't (and are not going to) convert blk_pwrite and
> blk_pread: these functions returns number of bytes on success, so to
> update them, we should change return type to int64_t as well, which
> will lead to investigating and updating all callers which is too much.
>
> So, blk_pread and blk_pwrite remain unchanged.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/sysemu/block-backend.h | 6 +++---
> block/block-backend.c | 10 +++++-----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH 03/12] block-backend: convert blk_co_pwritev_part to int64_t bytes, (continued)
- [PATCH 05/12] block-backend: rename _do_ helper functions to _co_do_, Vladimir Sementsov-Ogievskiy, 2021/10/06
- [PATCH 04/12] block-backend: convert blk_co_pdiscard to int64_t bytes, Vladimir Sementsov-Ogievskiy, 2021/10/06
- [PATCH 12/12] block-backend: drop INT_MAX restriction from blk_check_byte_request(), Vladimir Sementsov-Ogievskiy, 2021/10/06
- [PATCH 06/12] block-coroutine-wrapper.py: support BlockBackend first argument, Vladimir Sementsov-Ogievskiy, 2021/10/06
- [PATCH 08/12] block-backend: convert blk_foo wrappers to use int64_t bytes parameter, Vladimir Sementsov-Ogievskiy, 2021/10/06
- Re: [PATCH 08/12] block-backend: convert blk_foo wrappers to use int64_t bytes parameter,
Eric Blake <=
- [PATCH 02/12] block-backend: make blk_co_preadv() 64bit, Vladimir Sementsov-Ogievskiy, 2021/10/06
- [PATCH 07/12] block-backend: drop blk_prw, use block-coroutine-wrapper, Vladimir Sementsov-Ogievskiy, 2021/10/06
- [PATCH 09/12] block-backend: convert blk_co_copy_range to int64_t bytes, Vladimir Sementsov-Ogievskiy, 2021/10/06
- [PATCH 13/12] block-backend: fix blk_co_flush prototype to mention coroutine_fn, Vladimir Sementsov-Ogievskiy, 2021/10/07
- [PATCH 14/12] block-backend: update blk_co_pwrite() and blk_co_pread() wrappers, Vladimir Sementsov-Ogievskiy, 2021/10/07