[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 25/41] target/hexagon: Remove hexagon_cpu_tlb_fill
From: |
Richard Henderson |
Subject: |
[PATCH v4 25/41] target/hexagon: Remove hexagon_cpu_tlb_fill |
Date: |
Wed, 6 Oct 2021 10:22:51 -0700 |
The fallback code in cpu_loop_exit_sigsegv is sufficient
for hexagon linux-user.
Remove the code from cpu_loop that raises SIGSEGV.
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/hexagon/cpu_loop.c | 24 +-----------------------
target/hexagon/cpu.c | 23 -----------------------
2 files changed, 1 insertion(+), 46 deletions(-)
diff --git a/linux-user/hexagon/cpu_loop.c b/linux-user/hexagon/cpu_loop.c
index bee2a9e4ea..6b24cbaba9 100644
--- a/linux-user/hexagon/cpu_loop.c
+++ b/linux-user/hexagon/cpu_loop.c
@@ -28,8 +28,7 @@
void cpu_loop(CPUHexagonState *env)
{
CPUState *cs = env_cpu(env);
- int trapnr, signum, sigcode;
- target_ulong sigaddr;
+ int trapnr;
target_ulong syscallnum;
target_ulong ret;
@@ -39,10 +38,6 @@ void cpu_loop(CPUHexagonState *env)
cpu_exec_end(cs);
process_queued_cpu_work(cs);
- signum = 0;
- sigcode = 0;
- sigaddr = 0;
-
switch (trapnr) {
case EXCP_INTERRUPT:
/* just indicate that signals should be handled asap */
@@ -65,12 +60,6 @@ void cpu_loop(CPUHexagonState *env)
env->gpr[0] = ret;
}
break;
- case HEX_EXCP_FETCH_NO_UPAGE:
- case HEX_EXCP_PRIV_NO_UREAD:
- case HEX_EXCP_PRIV_NO_UWRITE:
- signum = TARGET_SIGSEGV;
- sigcode = TARGET_SEGV_MAPERR;
- break;
case EXCP_ATOMIC:
cpu_exec_step_atomic(cs);
break;
@@ -79,17 +68,6 @@ void cpu_loop(CPUHexagonState *env)
trapnr);
exit(EXIT_FAILURE);
}
-
- if (signum) {
- target_siginfo_t info = {
- .si_signo = signum,
- .si_errno = 0,
- .si_code = sigcode,
- ._sifields._sigfault._addr = sigaddr
- };
- queue_signal(env, info.si_signo, QEMU_SI_KILL, &info);
- }
-
process_pending_signals(env);
}
}
diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c
index 3338365c16..160a46a3d5 100644
--- a/target/hexagon/cpu.c
+++ b/target/hexagon/cpu.c
@@ -245,34 +245,11 @@ static void hexagon_cpu_init(Object *obj)
qdev_property_add_static(DEVICE(obj), &hexagon_lldb_stack_adjust_property);
}
-static bool hexagon_tlb_fill(CPUState *cs, vaddr address, int size,
- MMUAccessType access_type, int mmu_idx,
- bool probe, uintptr_t retaddr)
-{
-#ifdef CONFIG_USER_ONLY
- switch (access_type) {
- case MMU_INST_FETCH:
- cs->exception_index = HEX_EXCP_FETCH_NO_UPAGE;
- break;
- case MMU_DATA_LOAD:
- cs->exception_index = HEX_EXCP_PRIV_NO_UREAD;
- break;
- case MMU_DATA_STORE:
- cs->exception_index = HEX_EXCP_PRIV_NO_UWRITE;
- break;
- }
- cpu_loop_exit_restore(cs, retaddr);
-#else
-#error System mode not implemented for Hexagon
-#endif
-}
-
#include "hw/core/tcg-cpu-ops.h"
static const struct TCGCPUOps hexagon_tcg_ops = {
.initialize = hexagon_translate_init,
.synchronize_from_tb = hexagon_cpu_synchronize_from_tb,
- .tlb_fill = hexagon_tlb_fill,
};
static void hexagon_cpu_class_init(ObjectClass *c, void *data)
--
2.25.1
- [PATCH v4 24/41] target/cris: Make cris_cpu_tlb_fill sysemu only, (continued)
- [PATCH v4 24/41] target/cris: Make cris_cpu_tlb_fill sysemu only, Richard Henderson, 2021/10/06
- [PATCH v4 07/41] linux-user/host/x86: Populate host_signal.h, Richard Henderson, 2021/10/06
- [PATCH v4 09/41] linux-user/host/alpha: Populate host_signal.h, Richard Henderson, 2021/10/06
- [PATCH v4 37/41] target/s390x: Implement s390_cpu_record_sigsegv, Richard Henderson, 2021/10/06
- [PATCH v4 39/41] target/sparc: Make sparc_cpu_tlb_fill sysemu only, Richard Henderson, 2021/10/06
- [PATCH v4 11/41] linux-user/host/arm: Populate host_signal.h, Richard Henderson, 2021/10/06
- [PATCH v4 01/41] accel/tcg: Split out adjust_signal_pc, Richard Henderson, 2021/10/06
- [PATCH v4 08/41] linux-user/host/ppc: Populate host_signal.h, Richard Henderson, 2021/10/06
- [PATCH v4 02/41] accel/tcg: Move clear_helper_retaddr to cpu loop, Richard Henderson, 2021/10/06
- [PATCH v4 22/41] target/arm: Use cpu_loop_exit_sigsegv for mte tag lookup, Richard Henderson, 2021/10/06
- [PATCH v4 25/41] target/hexagon: Remove hexagon_cpu_tlb_fill,
Richard Henderson <=
- [PATCH v4 31/41] target/nios2: Implement nios2_cpu_record_sigsegv, Richard Henderson, 2021/10/06
- [PATCH v4 30/41] target/mips: Make mips_cpu_tlb_fill sysemu only, Richard Henderson, 2021/10/06
- [PATCH v4 32/41] linux-user/openrisc: Adjust signal for EXCP_RANGE, EXCP_FPE, Richard Henderson, 2021/10/06
- [PATCH v4 36/41] target/s390x: Use probe_access_flags in s390_probe_access, Richard Henderson, 2021/10/06
- [PATCH v4 35/41] target/riscv: Make riscv_cpu_tlb_fill sysemu only, Richard Henderson, 2021/10/06
- [PATCH v4 38/41] target/sh4: Make sh4_cpu_tlb_fill sysemu only, Richard Henderson, 2021/10/06
- [PATCH v4 40/41] target/xtensa: Make xtensa_cpu_tlb_fill sysemu only, Richard Henderson, 2021/10/06
- [PATCH v4 41/41] accel/tcg: Restrict TCGCPUOps::tlb_fill() to sysemu, Richard Henderson, 2021/10/06