[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 01/13] macfb: handle errors that occur during realize
From: |
Mark Cave-Ayland |
Subject: |
[PATCH v3 01/13] macfb: handle errors that occur during realize |
Date: |
Thu, 7 Oct 2021 10:33:55 +0100 |
Make sure any errors that occur within the macfb realize chain are detected
and handled correctly to prevent crashes and to ensure that error messages are
reported back to the user.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
hw/display/macfb.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/hw/display/macfb.c b/hw/display/macfb.c
index 76808b69cc..2b747a8de8 100644
--- a/hw/display/macfb.c
+++ b/hw/display/macfb.c
@@ -379,6 +379,10 @@ static void macfb_sysbus_realize(DeviceState *dev, Error
**errp)
MacfbState *ms = &s->macfb;
macfb_common_realize(dev, ms, errp);
+ if (*errp) {
+ return;
+ }
+
sysbus_init_mmio(SYS_BUS_DEVICE(s), &ms->mem_ctrl);
sysbus_init_mmio(SYS_BUS_DEVICE(s), &ms->mem_vram);
}
@@ -391,8 +395,15 @@ static void macfb_nubus_realize(DeviceState *dev, Error
**errp)
MacfbState *ms = &s->macfb;
ndc->parent_realize(dev, errp);
+ if (*errp) {
+ return;
+ }
macfb_common_realize(dev, ms, errp);
+ if (*errp) {
+ return;
+ }
+
memory_region_add_subregion(&nd->slot_mem, DAFB_BASE, &ms->mem_ctrl);
memory_region_add_subregion(&nd->slot_mem, VIDEO_BASE, &ms->mem_vram);
}
--
2.20.1
- [PATCH v3 00/13] macfb: fixes for booting MacOS, Mark Cave-Ayland, 2021/10/07
- [PATCH v3 01/13] macfb: handle errors that occur during realize,
Mark Cave-Ayland <=
- [PATCH v3 02/13] macfb: update macfb.c to use the Error API best practices, Mark Cave-Ayland, 2021/10/07
- [PATCH v3 03/13] macfb: fix invalid object reference in macfb_common_realize(), Mark Cave-Ayland, 2021/10/07
- [PATCH v3 04/13] macfb: fix overflow of color_palette array, Mark Cave-Ayland, 2021/10/07
- [PATCH v3 05/13] macfb: use memory_region_init_ram() in macfb_common_realize() for the framebuffer, Mark Cave-Ayland, 2021/10/07
- [PATCH v3 06/13] macfb: add trace events for reading and writing the control registers, Mark Cave-Ayland, 2021/10/07
- [PATCH v3 08/13] macfb: add qdev property to specify display type, Mark Cave-Ayland, 2021/10/07
- [PATCH v3 07/13] macfb: implement mode sense to allow display type to be detected, Mark Cave-Ayland, 2021/10/07