Re: [PATCH v3 8/9] bsd-user/mmap.c: Implement MAP

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jema

From:	Richard Henderson
Subject:	Re: [PATCH v3 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head
Date:	Sat, 9 Oct 2021 09:04:26 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/8/21 2:23 PM, Warner Losh wrote:

From: Kyle Evans<kevans@FreeBSD.org>

jemalloc requires a working MAP_EXCL. Ensure that no page is double
mapped when specified. In addition, use guest_range_valid_untagged to
test for valid ranges of pages rather than an incomplete inlined version
of the test that might be wrong.

Signed-off-by: Kyle Evans<kevans@FreeBSD.org>
Signed-off-by: Warner Losh<imp@bsdimp.com>
---
  bsd-user/mmap.c | 12 ++++++++----
  1 file changed, 8 insertions(+), 4 deletions(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v3 6/9] bsd-user/mmap.c: Convert to qemu_log logging for mmap debugging, (continued)
- [PATCH v3 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow, Warner Losh, 2021/10/08
  - Re: [PATCH v3 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow, Kyle Evans, 2021/10/14
- [PATCH v3 3/9] bsd-user/mmap.c: MAP_ symbols are defined, so no need for ifdefs, Warner Losh, 2021/10/08
  - Re: [PATCH v3 3/9] bsd-user/mmap.c: MAP_ symbols are defined, so no need for ifdefs, Kyle Evans, 2021/10/14
- [PATCH v3 5/9] bsd-user/mmap.c: mmap prefer MAP_ANON for BSD, Warner Losh, 2021/10/08
  - Re: [PATCH v3 5/9] bsd-user/mmap.c: mmap prefer MAP_ANON for BSD, Kyle Evans, 2021/10/14
- [PATCH v3 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head, Warner Losh, 2021/10/08
  - Re: [PATCH v3 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head, Richard Henderson <=
- [PATCH v3 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag, Warner Losh, 2021/10/08
  - Re: [PATCH v3 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag, Richard Henderson, 2021/10/09
  - Re: [PATCH v3 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag, Kyle Evans, 2021/10/17
- [PATCH v3 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail, Warner Losh, 2021/10/08
  - Re: [PATCH v3 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail, Kyle Evans, 2021/10/14

Prev by Date: Re: [PATCH v3 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag
Next by Date: Re: [PATCH] Trim some trailing space from human-readable output
Previous by thread: [PATCH v3 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head
Next by thread: [PATCH v3 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag
Index(es):
- Date
- Thread