Re: [PATCH 3/8] accel/tcg: Support TCG_TARGET_SIGNED_ADDR32 for softmmu

[Richard Henderson]

On 10/10/21 9:30 PM, WANG Xuerui wrote:
> > @@ -92,6 +93,9 @@ static inline size_t sizeof_tlb(CPUTLBDescFast *fast)
> >   
> >   static inline uintptr_t g2h_tlbe(const CPUTLBEntry *tlb, target_ulong gaddr)
> >   {
> > +    if (TCG_TARGET_SIGNED_ADDR32 && TARGET_LONG_BITS == 32) {
> It seems this branch's direction should always match that of the branch
> added below, so if TARGET_LONG_BITS == TARGET_LONG_BITS == 32 this
> invariant is broken? Or is this expected behavior?

The conditions should match, yes.

In revising the patch set I decided that the tcg backend should simply not set this flag 
for a 32-bit host.


r~