Re: [PATCH v2 24/24] configure: automatically parse command line for meson -D options

[Thomas Huth]

On 13/10/2021 19.00, Paolo Bonzini wrote:
> On 13/10/21 13:27, Thomas Huth wrote:
> > > +def fixup_options(options):
> > > +    # Meson <= 0.60 does not include the choices in array options, fix 
> > > that up
> > > +    for opt in options:
> > > +        if opt["name"] == "trace_backends":
> > > +            opt["choices"] = [
> > > +                "dtrace",
> > > +                "ftrace",
> > > +                "log",
> > > +                "nop",
> > > +                "simple",
> > > +                "syslog",
> > > +                "ust",
> > > +            ]
> >
> > Do we need a check for a fixed meson version here?
>
> No, on a fixed version of Meson it will just overwrite the existing array 
> with itself.  Once we can require a newer version, we'll remove the fixup.

Ok, then it sounds good to me:

Reviewed-by: Thomas Huth <thuth@redhat.com>