Re: [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext

From:	Richard Henderson
Subject:	Re: [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext
Date:	Thu, 14 Oct 2021 08:52:35 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/14/21 12:52 AM, LIU Zhiwei wrote:

@@ -360,6 +357,7 @@ static void riscv_cpu_reset(DeviceState *dev)
      mcc->parent_reset(dev);
  #ifndef CONFIG_USER_ONLY
+    env->misa_mxl = env->misa_mxl_max;


As we have set misa_mxl in cpu_init_fn, why set it again here?

I guess we could drop this for now, but we'd need to add it back as soon as we can modifyMXL in write_misa, as this is part of the reset spec.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 00/13] target/riscv: Rationalize XLEN and operand length, Richard Henderson, 2021/10/13
- [PATCH v2 02/13] target/riscv: Create RISCVMXL enumeration, Richard Henderson, 2021/10/13
- [PATCH v2 01/13] target/riscv: Move cpu_get_tb_cpu_state out of line, Richard Henderson, 2021/10/13
- [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext, Richard Henderson, 2021/10/13
  - Re: [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext, LIU Zhiwei, 2021/10/14
    - Re: [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext, Richard Henderson <=
  - Re: [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext, Alistair Francis, 2021/10/15
- [PATCH v2 05/13] target/riscv: Add MXL/SXL/UXL to TB_FLAGS, Richard Henderson, 2021/10/13
  - Re: [PATCH v2 05/13] target/riscv: Add MXL/SXL/UXL to TB_FLAGS, LIU Zhiwei, 2021/10/14
    - Re: [PATCH v2 05/13] target/riscv: Add MXL/SXL/UXL to TB_FLAGS, Richard Henderson, 2021/10/14
  - Re: [PATCH v2 05/13] target/riscv: Add MXL/SXL/UXL to TB_FLAGS, Alistair Francis, 2021/10/15
- [PATCH v2 06/13] target/riscv: Use REQUIRE_64BIT in amo_check64, Richard Henderson, 2021/10/13
  - Re: [PATCH v2 06/13] target/riscv: Use REQUIRE_64BIT in amo_check64, LIU Zhiwei, 2021/10/14
  - Re: [PATCH v2 06/13] target/riscv: Use REQUIRE_64BIT in amo_check64, Alistair Francis, 2021/10/15
- [PATCH v2 04/13] target/riscv: Replace riscv_cpu_is_32bit with riscv_cpu_mxl, Richard Henderson, 2021/10/13
  - Re: [PATCH v2 04/13] target/riscv: Replace riscv_cpu_is_32bit with riscv_cpu_mxl, LIU Zhiwei, 2021/10/14

Prev by Date: Re: [PATCH v2 09/13] target/riscv: Replace DisasContext.w with DisasContext.ol
Next by Date: Re: [PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd
Previous by thread: Re: [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext
Next by thread: Re: [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext
Index(es):
- Date
- Thread