[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] target/ppc: Fix XER access in gdbstub
From: |
David Gibson |
Subject: |
Re: [PATCH 2/4] target/ppc: Fix XER access in gdbstub |
Date: |
Fri, 15 Oct 2021 11:31:25 +1100 |
On Thu, Oct 14, 2021 at 07:32:32PM -0300, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst <matheus.ferst@eldorado.org.br>
>
> The value of XER is split in multiple fields of CPUPPCState, like
> env->xer and env->so. To get/set the whole register from gdb, we should
> use cpu_read_xer/cpu_write_xer.
>
> Fixes: da91a00f191f ("target-ppc: Split out SO, OV, CA fields from XER")
> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
Applied to ppc-for-6.2.
> ---
> target/ppc/gdbstub.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c
> index 1808a150e4..105c2f7dd1 100644
> --- a/target/ppc/gdbstub.c
> +++ b/target/ppc/gdbstub.c
> @@ -159,7 +159,7 @@ int ppc_cpu_gdb_read_register(CPUState *cs, GByteArray
> *buf, int n)
> gdb_get_regl(buf, env->ctr);
> break;
> case 69:
> - gdb_get_reg32(buf, env->xer);
> + gdb_get_reg32(buf, cpu_read_xer(env));
> break;
> case 70:
> gdb_get_reg32(buf, env->fpscr);
> @@ -217,7 +217,7 @@ int ppc_cpu_gdb_read_register_apple(CPUState *cs,
> GByteArray *buf, int n)
> gdb_get_reg64(buf, env->ctr);
> break;
> case 69 + 32:
> - gdb_get_reg32(buf, env->xer);
> + gdb_get_reg32(buf, cpu_read_xer(env));
> break;
> case 70 + 32:
> gdb_get_reg64(buf, env->fpscr);
> @@ -269,7 +269,7 @@ int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t
> *mem_buf, int n)
> env->ctr = ldtul_p(mem_buf);
> break;
> case 69:
> - env->xer = ldl_p(mem_buf);
> + cpu_write_xer(env, ldl_p(mem_buf));
> break;
> case 70:
> /* fpscr */
> @@ -319,7 +319,7 @@ int ppc_cpu_gdb_write_register_apple(CPUState *cs,
> uint8_t *mem_buf, int n)
> env->ctr = ldq_p(mem_buf);
> break;
> case 69 + 32:
> - env->xer = ldl_p(mem_buf);
> + cpu_write_xer(env, ldl_p(mem_buf));
> break;
> case 70 + 32:
> /* fpscr */
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature