[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/15] iotests/051: Fix typo
From: |
Kevin Wolf |
Subject: |
[PULL 06/15] iotests/051: Fix typo |
Date: |
Fri, 15 Oct 2021 16:46:31 +0200 |
The iothread isn't called 'iothread0', but 'thread0'. Depending on the
order that properties are parsed, the error message may change from the
expected one to another one saying that the iothread doesn't exist.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20211008133442.141332-7-kwolf@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/051 | 2 +-
tests/qemu-iotests/051.pc.out | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index 7bf29343d7..1d2fa93a11 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -199,7 +199,7 @@ case "$QEMU_DEFAULT_MACHINE" in
# virtio-blk enables the iothread only when the driver initialises the
# device, so a second virtio-blk device can't be added even with the
# same iothread. virtio-scsi allows this.
- run_qemu $iothread -device
virtio-blk-pci,drive=disk,iothread=iothread0,share-rw=on
+ run_qemu $iothread -device
virtio-blk-pci,drive=disk,iothread=thread0,share-rw=on
run_qemu $iothread -device
virtio-scsi,id=virtio-scsi1,iothread=thread0 -device
scsi-hd,bus=virtio-scsi1.0,drive=disk,share-rw=on
;;
*)
diff --git a/tests/qemu-iotests/051.pc.out b/tests/qemu-iotests/051.pc.out
index afe7632964..063e4fc584 100644
--- a/tests/qemu-iotests/051.pc.out
+++ b/tests/qemu-iotests/051.pc.out
@@ -183,9 +183,9 @@ Testing: -drive
file=TEST_DIR/t.qcow2,if=none,node-name=disk -object iothread,id
QEMU X.Y.Z monitor - type 'help' for more information
(qemu) QEMU_PROG: -device scsi-hd,bus=virtio-scsi1.0,drive=disk,share-rw=on:
Cannot change iothread of active block backend
-Testing: -drive file=TEST_DIR/t.qcow2,if=none,node-name=disk -object
iothread,id=thread0 -device virtio-scsi,iothread=thread0,id=virtio-scsi0
-device scsi-hd,bus=virtio-scsi0.0,drive=disk,share-rw=on -device
virtio-blk-pci,drive=disk,iothread=iothread0,share-rw=on
+Testing: -drive file=TEST_DIR/t.qcow2,if=none,node-name=disk -object
iothread,id=thread0 -device virtio-scsi,iothread=thread0,id=virtio-scsi0
-device scsi-hd,bus=virtio-scsi0.0,drive=disk,share-rw=on -device
virtio-blk-pci,drive=disk,iothread=thread0,share-rw=on
QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) QEMU_PROG: -device
virtio-blk-pci,drive=disk,iothread=iothread0,share-rw=on: Cannot change
iothread of active block backend
+(qemu) QEMU_PROG: -device
virtio-blk-pci,drive=disk,iothread=thread0,share-rw=on: Cannot change iothread
of active block backend
Testing: -drive file=TEST_DIR/t.qcow2,if=none,node-name=disk -object
iothread,id=thread0 -device virtio-scsi,iothread=thread0,id=virtio-scsi0
-device scsi-hd,bus=virtio-scsi0.0,drive=disk,share-rw=on -device
virtio-scsi,id=virtio-scsi1,iothread=thread0 -device
scsi-hd,bus=virtio-scsi1.0,drive=disk,share-rw=on
QEMU X.Y.Z monitor - type 'help' for more information
--
2.31.1
- [PULL 00/15] qdev: Add JSON -device, Kevin Wolf, 2021/10/15
- [PULL 01/15] net: Introduce NetClientInfo.check_peer_type(), Kevin Wolf, 2021/10/15
- [PULL 02/15] net/vhost-user: Fix device compatibility check, Kevin Wolf, 2021/10/15
- [PULL 03/15] net/vhost-vdpa: Fix device compatibility check, Kevin Wolf, 2021/10/15
- [PULL 04/15] qom: Reduce use of error_propagate(), Kevin Wolf, 2021/10/15
- [PULL 05/15] iotests/245: Fix type for iothread property, Kevin Wolf, 2021/10/15
- [PULL 06/15] iotests/051: Fix typo,
Kevin Wolf <=
- [PULL 07/15] qdev: Avoid using string visitor for properties, Kevin Wolf, 2021/10/15
- [PULL 08/15] qdev: Make DeviceState.id independent of QemuOpts, Kevin Wolf, 2021/10/15
- [PULL 10/15] qemu-option: Allow deleting opts during qemu_opts_foreach(), Kevin Wolf, 2021/10/15
- [PULL 11/15] qdev: Add Error parameter to hide_device() callbacks, Kevin Wolf, 2021/10/15
- [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts, Kevin Wolf, 2021/10/15
- [PULL 12/15] virtio-net: Store failover primary opts pointer locally, Kevin Wolf, 2021/10/15
- [PULL 13/15] virtio-net: Avoid QemuOpts in failover_find_primary_device(), Kevin Wolf, 2021/10/15
- [PULL 09/15] softmmu/qdev-monitor: add error handling in qdev_set_id, Kevin Wolf, 2021/10/15
- [PULL 15/15] vl: Enable JSON syntax for -device, Kevin Wolf, 2021/10/15
- Re: [PULL 00/15] qdev: Add JSON -device, Richard Henderson, 2021/10/15