Re: [PATCH v3 3/6] target/riscv: zfh: half-precision convert and move

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/6] target/riscv: zfh: half-precision convert and move

From:	Richard Henderson
Subject:	Re: [PATCH v3 3/6] target/riscv: zfh: half-precision convert and move
Date:	Sun, 17 Oct 2021 22:53:02 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/17/21 4:59 PM, Alistair Francis wrote:

+#if defined(TARGET_RISCV64)
+    /* 16 bits -> 64 bits */
+    tcg_gen_ext16s_tl(dest, cpu_fpr[a->rs1]);
+#else
+    /* 16 bits -> 32 bits */
+    tcg_gen_extrl_i64_i32(dest, cpu_fpr[a->rs1]);
+    tcg_gen_ext16s_tl(dest, dest);
+#endif

Can we use is_32bit(ctx) instead?


No.  This is about sizeof(target_long), not the current cpu state.

It would be possible to use

    tcg_gen_trunc_i64_tl
    tcg_gen_ext16s_tl

but we have a couple of other instances of the same thing.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v3 1/6] target/riscv: zfh: half-precision load and store, (continued)
- [PATCH v3 2/6] target/riscv: zfh: half-precision computational, frank . chang, 2021/10/16
  - Re: [PATCH v3 2/6] target/riscv: zfh: half-precision computational, Alistair Francis, 2021/10/17
- [PATCH v3 4/6] target/riscv: zfh: half-precision floating-point compare, frank . chang, 2021/10/16
  - Re: [PATCH v3 4/6] target/riscv: zfh: half-precision floating-point compare, Alistair Francis, 2021/10/17
- [PATCH v3 5/6] target/riscv: zfh: half-precision floating-point classify, frank . chang, 2021/10/16
  - Re: [PATCH v3 5/6] target/riscv: zfh: half-precision floating-point classify, Alistair Francis, 2021/10/17
- [PATCH v3 3/6] target/riscv: zfh: half-precision convert and move, frank . chang, 2021/10/16
  - Re: [PATCH v3 3/6] target/riscv: zfh: half-precision convert and move, Alistair Francis, 2021/10/17
    - Re: [PATCH v3 3/6] target/riscv: zfh: half-precision convert and move, Richard Henderson <=
  - Re: [PATCH v3 3/6] target/riscv: zfh: half-precision convert and move, Alistair Francis, 2021/10/18
- [PATCH v3 6/6] target/riscv: zfh: implement zfhmin extension, frank . chang, 2021/10/16
  - Re: [PATCH v3 6/6] target/riscv: zfh: implement zfhmin extension, Alistair Francis, 2021/10/17
- Re: [PATCH v3 0/6] target/riscv: support Zfh, Zfhmin extension v0.1, Richard Henderson, 2021/10/16
  - Re: [PATCH v3 0/6] target/riscv: support Zfh, Zfhmin extension v0.1, Frank Chang, 2021/10/16

Prev by Date: Re: [PATCH v8 32/78] target/riscv: rvv-1.0: iota instruction
Next by Date: Re: [PATCH v8 31/78] target/riscv: rvv-1.0: set-X-first mask bit instructions
Previous by thread: Re: [PATCH v3 3/6] target/riscv: zfh: half-precision convert and move
Next by thread: Re: [PATCH v3 3/6] target/riscv: zfh: half-precision convert and move
Index(es):
- Date
- Thread