[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/48] tcg/optimize: Move prev_mb into OptContext
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 05/48] tcg/optimize: Move prev_mb into OptContext |
Date: |
Tue, 19 Oct 2021 16:44:18 +0100 |
User-agent: |
mu4e 1.7.0; emacs 28.0.60 |
Richard Henderson <richard.henderson@linaro.org> writes:
> This will expose the variable to subroutines that
> will be broken out of tcg_optimize.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/optimize.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 627a5b39f6..b875d76354 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -46,6 +46,7 @@ typedef struct TempOptInfo {
>
> typedef struct OptContext {
> TCGContext *tcg;
> + TCGOp *prev_mb;
> TCGTempSet temps_used;
> } OptContext;
>
> @@ -609,7 +610,7 @@ static bool swap_commutative2(TCGArg *p1, TCGArg *p2)
> void tcg_optimize(TCGContext *s)
> {
> int nb_temps, nb_globals, i;
> - TCGOp *op, *op_next, *prev_mb = NULL;
> + TCGOp *op, *op_next;
> OptContext ctx = { .tcg = s };
Do we need to add .prev_mb = NULL to ensure the ctx doesn't start
corrupted or does the partial initialisation ensure the rest is zeroed
out?
Otherwise:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- [PATCH v2 17/48] tcg/optimize: Split out fold_brcond2, (continued)
- [PATCH v2 17/48] tcg/optimize: Split out fold_brcond2, Richard Henderson, 2021/10/07
- [PATCH v2 26/48] tcg/optimize: Split out fold_count_zeros, Richard Henderson, 2021/10/07
- [PATCH v2 27/48] tcg/optimize: Split out fold_bswap, Richard Henderson, 2021/10/07
- [PATCH v2 34/48] tcg/optimize: Split out fold_to_not, Richard Henderson, 2021/10/07
- [PATCH v2 03/48] tcg/optimize: Remove do_default label, Richard Henderson, 2021/10/07
- [PATCH v2 05/48] tcg/optimize: Move prev_mb into OptContext, Richard Henderson, 2021/10/07
- [PATCH v2 09/48] tcg/optimize: Drop nb_oargs, nb_iargs locals, Richard Henderson, 2021/10/07
- [PATCH v2 04/48] tcg/optimize: Change tcg_opt_gen_{mov, movi} interface, Richard Henderson, 2021/10/07
- [PATCH v2 10/48] tcg/optimize: Change fail return for do_constant_folding_cond*, Richard Henderson, 2021/10/07