|
From: | Richard Henderson |
Subject: | Re: [PATCH v3 07/22] host-utils: add 128-bit quotient support to divu128/divs128 |
Date: | Thu, 21 Oct 2021 14:14:57 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 9/10/21 4:26 AM, Luis Pires wrote:
These will be used to implement new decimal floating point instructions from Power ISA 3.1. A new argument, prem, was added to divu128/divs128 to receive the remainder, freeing up phigh to receive the high 64 bits of the quotient. Signed-off-by: Luis Pires <luis.pires@eldorado.org.br>
Why not return the remainder? That would avoid the need for an extra argument, and the need for a conditional vs prem inside the division functions.
Modulo that, the code looks good so, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |