[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC configurat
From: |
Alistair Francis |
Subject: |
[PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC configuration |
Date: |
Fri, 22 Oct 2021 16:01:29 +1000 |
From: Alistair Francis <alistair.francis@wdc.com>
Using a macro for the PLIC configuration doesn't make the code any
easier to read. Instead it makes it harder to figure out what is going
on, so let's remove it.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
include/hw/riscv/virt.h | 1 -
hw/riscv/virt.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h
index d9105c1886..b8ef99f348 100644
--- a/include/hw/riscv/virt.h
+++ b/include/hw/riscv/virt.h
@@ -73,7 +73,6 @@ enum {
VIRTIO_NDEV = 0x35 /* Arbitrary maximum number of interrupts */
};
-#define VIRT_PLIC_HART_CONFIG "MS"
#define VIRT_PLIC_NUM_SOURCES 127
#define VIRT_PLIC_NUM_PRIORITIES 7
#define VIRT_PLIC_PRIORITY_BASE 0x04
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index ec0cb69b8c..2d3a8ec405 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -758,7 +758,7 @@ static char *plic_hart_config_string(int hart_count)
int i;
for (i = 0; i < hart_count; i++) {
- vals[i] = VIRT_PLIC_HART_CONFIG;
+ vals[i] = "MS";
}
vals[i] = NULL;
--
2.31.1
- [PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC configuration,
Alistair Francis <=
- [PATCH v2 2/5] hw/riscv: boot: Add a PLIC config string function, Alistair Francis, 2021/10/22
- [PATCH v2 3/5] hw/riscv: sifive_u: Use the PLIC config helper function, Alistair Francis, 2021/10/22
- [PATCH v2 4/5] hw/riscv: microchip_pfsoc: Use the PLIC config helper function, Alistair Francis, 2021/10/22
- [PATCH v2 5/5] hw/riscv: virt: Use the PLIC config helper function, Alistair Francis, 2021/10/22
- Re: [PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC configuration, Philippe Mathieu-Daudé, 2021/10/22