Re: [PATCH 15/33] target/ppc: Implement Vector Insert from GPR using GPR index insns

[Richard Henderson]

On 10/21/21 12:45 PM, matheus.ferst@eldorado.org.br wrote:
> +#if defined(TARGET_PPC64)
> +    return do_vinsx(ctx, a->vrt, size, right, cpu_gpr[a->vra], cpu_gpr[a->vrb],
> +                    gen_helper);
> +#else
> +    bool ok;
> +    TCGv_i64 val;
> +
> +    val = tcg_temp_new_i64();
> +    tcg_gen_extu_tl_i64(val, cpu_gpr[a->vrb]);
> +
> +    ok = do_vinsx(ctx, a->vrt, size, right, cpu_gpr[a->vra], val, gen_helper);
> +
> +    tcg_temp_free_i64(val);
> +    return ok;
> +#endif

Oh, and what's all this?

Either this isn't defined for !PPC64 at all, or you should just use target_ulong and not 
do any ifdeffing at all.

r~