|
From: | Richard Henderson |
Subject: | Re: [PATCH 21/33] target/ppc: moved stxv and lxv from legacy to decodtree |
Date: | Sat, 23 Oct 2021 13:39:23 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 10/23/21 1:34 PM, Richard Henderson wrote:
On 10/21/21 12:45 PM, matheus.ferst@eldorado.org.br wrote:+static bool do_lstxv(DisasContext *ctx, int ra, int displ, + int rt, bool store)You need an int64_t displ before you add PLXV et al. What happened to passing in arg_D as for the other integer instructions?+ do_ea_calc(ctx, ra, tcg_const_tl(displ), ea); + + if (ctx->le_mode) { + gen_addr_add(ctx, ea, ea, 8); + offset = -8; + } else { + offset = 8; + }Adjust displ for le_mode, then you don't have to do the addition twice.
Nevermind, next patch fixes this one. Fold the 3 lines back for a Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |