qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 15/33] target/mips: Convert MSA load/store instruction format


From: Richard Henderson
Subject: Re: [PATCH 15/33] target/mips: Convert MSA load/store instruction format to decodetree
Date: Sat, 23 Oct 2021 21:53:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote:
+#define TRANS_DF_E(NAME, trans_func, gen_func) \
+        TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \
+                    gen_func##_b, gen_func##_h, gen_func##_w, gen_func##_d)

I think this would be better as a table.

#define TRANS_DF_E(NAME, trans_func, gen_func) \
    static void (* const NAME##_tab[4])(TCGv_ptr, TCGv_i32, TCGV) = { \
        gen_func##_b, gen_func##_h, gen_func##_w, gen_func##_d)       \
    };                                                                \
    TRANS_MSA(trans_func, NAME##_tag[a->df])


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]