Re: Commit abb0cd93494 breaks -singlestep -d in_asm,cpu with qemu-system-sh4

[Richard Henderson]

On 10/25/21 2:16 PM, BALATON Zoltan wrote:
> Hello,
>
> Commit abb0cd93494 (accel/tcg: Split out log_cpu_exec) seems to have broken -singlestep -d 
> in_asm,cpu output with qemu-system-sh4 after a delay slot. Since that commit I get:
>
> pc=0xac80003e sr=0x500000f1 pr=0x00000000 fpscr=0x00040001
> spc=0x00000000 ssr=0x00000000 gbr=0x00000000 vbr=0x00000000
> sgr=0x00000000 dbr=0x00000000 delayed_pc=0x00000000 fpul=0x00000000
> r0=0x8cc9d000 r1=0xacc9d000 r2=0xe0000000 r3=0x8c800000
> r4=0x00000000 r5=0x00000000 r6=0x00000000 r7=0x00000000
> r8=0x00000000 r9=0x00000000 r10=0x00000000 r11=0x00000000
> r12=0x00000000 r13=0x00000000 r14=0x00000000 r15=0x00000000
> r16=0x00000000 r17=0x500000f0 r18=0x00000000 r19=0x00000000
> r20=0x00000000 r21=0x00000000 r22=0x00000000 r23=0x00000000
> ----------------
> IN:
> 0xac800040:  bt.s       0xac80001a
>
> pc=0xac800040 sr=0x500000f1 pr=0x00000000 fpscr=0x00040001
> spc=0x00000000 ssr=0x00000000 gbr=0x00000000 vbr=0x00000000
> sgr=0x00000000 dbr=0x00000000 delayed_pc=0x00000000 fpul=0x00000000
> r0=0x8cc9cfe0 r1=0xacc9d000 r2=0xe0000000 r3=0x8c800000
> r4=0x00000000 r5=0x00000000 r6=0x00000000 r7=0x00000000
> r8=0x00000000 r9=0x00000000 r10=0x00000000 r11=0x00000000
> r12=0x00000000 r13=0x00000000 r14=0x00000000 r15=0x00000000
> r16=0x00000000 r17=0x500000f0 r18=0x00000000 r19=0x00000000
> r20=0x00000000 r21=0x00000000 r22=0x00000000 r23=0x00000000
> ----------------
> IN:
> 0xac800042:  add        #-32,r1
>
> pc=0xac800042 sr=0x500000f1 pr=0x00000000 fpscr=0x00040001
> spc=0x00000000 ssr=0x00000000 gbr=0x00000000 vbr=0x00000000
> sgr=0x00000000 dbr=0x00000000 delayed_pc=0xac80001a fpul=0x00000000
> r0=0x8cc9cfe0 r1=0xacc9d000 r2=0xe0000000 r3=0x8c800000
> r4=0x00000000 r5=0x00000000 r6=0x00000000 r7=0x00000000
> r8=0x00000000 r9=0x00000000 r10=0x00000000 r11=0x00000000
> r12=0x00000000 r13=0x00000000 r14=0x00000000 r15=0x00000000
> r16=0x00000000 r17=0x500000f0 r18=0x00000000 r19=0x00000000
> r20=0x00000000 r21=0x00000000 r22=0x00000000 r23=0x00000000
> in conditional delay slot (delayed_pc=0xac80001a)
> pc=0xac80001a sr=0x500000f1 pr=0x00000000 fpscr=0x00040001
> spc=0x00000000 ssr=0x00000000 gbr=0x00000000 vbr=0x00000000
> sgr=0x00000000 dbr=0x00000000 delayed_pc=0xac80001a fpul=0x00000000
> r0=0x8cc9cfe0 r1=0xacc9cfe0 r2=0xe0000000 r3=0x8c800000
> r4=0x00000000 r5=0x00000000 r6=0x00000000 r7=0x00000000
> r8=0x00000000 r9=0x00000000 r10=0x00000000 r11=0x00000000
> r12=0x00000000 r13=0x00000000 r14=0x00000000 r15=0x00000000
> r16=0x00000000 r17=0x500000f0 r18=0x00000000 r19=0x00000000
> r20=0x00000000 r21=0x00000000 r22=0x00000000 r23=0x00000000
> pc=0xac80001c sr=0x500000f1 pr=0x00000000 fpscr=0x00040001
> spc=0x00000000 ssr=0x00000000 gbr=0x00000000 vbr=0x00000000
> sgr=0x00000000 dbr=0x00000000 delayed_pc=0xac80001a fpul=0x00000000
> r0=0x8cc9cfe0 r1=0xacc9cfe0 r2=0xe0000000 r3=0x8c800000
> r4=0x00000000 r5=0x00000000 r6=0x00000000 r7=0x00000000
> r8=0x00000000 r9=0x00000000 r10=0x00000000 r11=0x00000000
> r12=0x00000000 r13=0x00000000 r14=0x00000000 r15=0x00000000
> r16=0x00000000 r17=0x500000f0 r18=0x00000000 r19=0x00000000
> r20=0x00000000 r21=0x00000000 r22=0x00000000 r23=0x00000000
>
> After the first delay slot no more in_asm output is printed.

I don't think it's broken, it's just logging more (lots more) than it used to do -- that 
was part of the changes in that patch set.  If I turn off logging, and let -singlestep run 
by itself, it takes some time but I do get to a login prompt.


r~