Re: [PATCH v1 24/28] tracing: excise the tcg related from tracetool

[Richard Henderson]

On 10/26/21 3:22 AM, Alex Bennée wrote:
> diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h
> index 1c2e7a8ed3..7b6ca975ef 100644
> --- a/include/exec/helper-gen.h
> +++ b/include/exec/helper-gen.h
> @@ -79,8 +79,6 @@ static inline void glue(gen_helper_, 
> name)(dh_retvar_decl(ret)          \
>   }
>   
>   #include "helper.h"
> -#include "trace/generated-helpers.h"
> -#include "trace/generated-helpers-wrappers.h"
>   #include "accel/tcg/tcg-runtime.h"
>   #include "accel/tcg/plugin-helpers.h"
>   
> diff --git a/include/exec/helper-proto.h b/include/exec/helper-proto.h
> index ba100793a7..c4b1bda632 100644
> --- a/include/exec/helper-proto.h
> +++ b/include/exec/helper-proto.h
> @@ -38,7 +38,6 @@ dh_ctype(ret) HELPER(name) (dh_ctype(t1), dh_ctype(t2), 
> dh_ctype(t3), \
>   #define IN_HELPER_PROTO
>   
>   #include "helper.h"
> -#include "trace/generated-helpers.h"
>   #include "accel/tcg/tcg-runtime.h"
>   #include "accel/tcg/plugin-helpers.h"
>   
> diff --git a/include/exec/helper-tcg.h b/include/exec/helper-tcg.h
> index 16cd318b83..3933258f1a 100644
> --- a/include/exec/helper-tcg.h
> +++ b/include/exec/helper-tcg.h
> @@ -59,7 +59,6 @@
>       | dh_typemask(t5, 5) | dh_typemask(t6, 6) | dh_typemask(t7, 7) },
>   
>   #include "helper.h"
> -#include "trace/generated-helpers.h"
>   #include "accel/tcg/tcg-runtime.h"
>   #include "accel/tcg/plugin-helpers.h"
>   

These should have gone with the previous patch.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~