qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V4 1/3] net/filter: Remove vnet_hdr from filter-mirror and fi


From: Jason Wang
Subject: Re: [PATCH V4 1/3] net/filter: Remove vnet_hdr from filter-mirror and filter-redirector
Date: Wed, 27 Oct 2021 14:24:21 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0


在 2021/10/27 下午2:19, Zhang, Chen 写道:
mirror,id=id,netdev=netdevid,outdev=chardevid,queue=all|rx|tx[,vnet_hdr
_support][,position=head|tail|id=<id>][,insert=behind|before]``
+    ``-object
+ filter-mirror,id=id,netdev=netdevid,outdev=chardevid,queue=all|rx|tx
+ [,position=head|tail|id=<id>][,insert=behind|before]``
I wonder if we break management layer. If yes, maybe it's better to keep the
vnet_hdr_support here.
Yes and no,   With this series of patches, filters have ability to automatically
Configure the appropriate vnet_hdr_support flag according to the current 
environment.
And can report error when can't fixing the vnet_hdr(The user cannot fix it from 
the previous way ).
So I think no need for the user to configure this option, some relevant 
background knowledge required.

For the management layer, keep the vnet_hdr_support may be meaningless except 
for compatibility.
In this situation, Do you think we still need to keep the vnet_hdr_support for 
management layer?


So it depends on whether management layer like libvirt has already supported this. If yes, we may get errors using new qemu with old libvirt?

Thanks

Enable/disable it do the same things for filters.

Thanks
Chen





reply via email to

[Prev in Thread] Current Thread [Next in Thread]