[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 19/23] hw/intc/sh_intc: Remove unneeded local variable initial
From: |
BALATON Zoltan |
Subject: |
[PATCH v4 19/23] hw/intc/sh_intc: Remove unneeded local variable initialisers |
Date: |
Thu, 28 Oct 2021 21:27:05 +0200 |
The sh_intc_locate function will either init these or not return so no
need to initialise them.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/intc/sh_intc.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/hw/intc/sh_intc.c b/hw/intc/sh_intc.c
index ed0a5f87cc..1f4e1b9370 100644
--- a/hw/intc/sh_intc.c
+++ b/hw/intc/sh_intc.c
@@ -196,14 +196,13 @@ static void sh_intc_toggle_mask(struct intc_desc *desc,
intc_enum id,
}
}
-static uint64_t sh_intc_read(void *opaque, hwaddr offset,
- unsigned size)
+static uint64_t sh_intc_read(void *opaque, hwaddr offset, unsigned size)
{
struct intc_desc *desc = opaque;
- intc_enum *enum_ids = NULL;
- unsigned int first = 0;
- unsigned int width = 0;
- unsigned int mode = 0;
+ intc_enum *enum_ids;
+ unsigned int first;
+ unsigned int width;
+ unsigned int mode;
unsigned long *valuep;
sh_intc_locate(desc, (unsigned long)offset, &valuep,
@@ -216,12 +215,12 @@ static void sh_intc_write(void *opaque, hwaddr offset,
uint64_t value, unsigned size)
{
struct intc_desc *desc = opaque;
- intc_enum *enum_ids = NULL;
- unsigned int first = 0;
- unsigned int width = 0;
- unsigned int mode = 0;
- unsigned int k;
+ intc_enum *enum_ids;
+ unsigned int first;
+ unsigned int width;
+ unsigned int mode;
unsigned long *valuep;
+ unsigned int k;
unsigned long mask;
trace_sh_intc_write(size, offset, value);
--
2.21.4
- [PATCH v4 07/23] hw/char/sh_serial: Add device id to trace output, (continued)
- [PATCH v4 07/23] hw/char/sh_serial: Add device id to trace output, BALATON Zoltan, 2021/10/28
- [PATCH v4 08/23] hw/intc/sh_intc: Use existing macro instead of local one, BALATON Zoltan, 2021/10/28
- [PATCH v4 10/23] hw/intc/sh_intc: Rename iomem region, BALATON Zoltan, 2021/10/28
- [PATCH v4 03/23] hw/sh4: Change debug printfs to traces, BALATON Zoltan, 2021/10/28
- [PATCH v4 15/23] hw/intc/sh_intc: Inline and drop sh_intc_source() function, BALATON Zoltan, 2021/10/28
- [PATCH v4 12/23] hw/intc/sh_intc: Move sh_intc_register() closer to its only user, BALATON Zoltan, 2021/10/28
- [PATCH v4 14/23] hw/intc/sh_intc: Use array index instead of pointer arithmetics, BALATON Zoltan, 2021/10/28
- [PATCH v4 19/23] hw/intc/sh_intc: Remove unneeded local variable initialisers,
BALATON Zoltan <=
- [PATCH v4 09/23] hw/intc/sh_intc: Turn some defines into an enum, BALATON Zoltan, 2021/10/28
- [PATCH v4 06/23] hw/char/sh_serial: QOM-ify, BALATON Zoltan, 2021/10/28
[PATCH v4 13/23] hw/intc/sh_intc: Remove excessive parenthesis, BALATON Zoltan, 2021/10/28
[PATCH v4 11/23] hw/intc/sh_intc: Drop another useless macro, BALATON Zoltan, 2021/10/28
[PATCH v4 23/23] hw/timer/sh_timer: Fix timer memory region size, BALATON Zoltan, 2021/10/28