[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 18/60] tcg/optimize: Use a boolean to avoid a mass of continues
From: |
Richard Henderson |
Subject: |
[PULL v2 18/60] tcg/optimize: Use a boolean to avoid a mass of continues |
Date: |
Thu, 28 Oct 2021 21:32:47 -0700 |
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/optimize.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index 368457f4a2..699476e2f1 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -713,6 +713,7 @@ void tcg_optimize(TCGContext *s)
uint64_t z_mask, partmask, affected, tmp;
TCGOpcode opc = op->opc;
const TCGOpDef *def;
+ bool done = false;
/* Calls are special. */
if (opc == INDEX_op_call) {
@@ -1212,8 +1213,8 @@ void tcg_optimize(TCGContext *s)
allocator where needed and possible. Also detect copies. */
switch (opc) {
CASE_OP_32_64_VEC(mov):
- tcg_opt_gen_mov(&ctx, op, op->args[0], op->args[1]);
- continue;
+ done = tcg_opt_gen_mov(&ctx, op, op->args[0], op->args[1]);
+ break;
case INDEX_op_dup_vec:
if (arg_is_const(op->args[1])) {
@@ -1602,7 +1603,9 @@ void tcg_optimize(TCGContext *s)
break;
}
- finish_folding(&ctx, op);
+ if (!done) {
+ finish_folding(&ctx, op);
+ }
/* Eliminate duplicate and redundant fence instructions. */
if (ctx.prev_mb) {
--
2.25.1
- [PULL v2 09/60] tcg/optimize: Change tcg_opt_gen_{mov, movi} interface, (continued)
- [PULL v2 09/60] tcg/optimize: Change tcg_opt_gen_{mov, movi} interface, Richard Henderson, 2021/10/29
- [PULL v2 06/60] tcg/optimize: Rename "mask" to "z_mask", Richard Henderson, 2021/10/29
- [PULL v2 07/60] tcg/optimize: Split out OptContext, Richard Henderson, 2021/10/29
- [PULL v2 08/60] tcg/optimize: Remove do_default label, Richard Henderson, 2021/10/29
- [PULL v2 10/60] tcg/optimize: Move prev_mb into OptContext, Richard Henderson, 2021/10/29
- [PULL v2 13/60] tcg/optimize: Split out fold_call, Richard Henderson, 2021/10/29
- [PULL v2 12/60] tcg/optimize: Split out copy_propagate, Richard Henderson, 2021/10/29
- [PULL v2 15/60] tcg/optimize: Change fail return for do_constant_folding_cond*, Richard Henderson, 2021/10/29
- [PULL v2 17/60] tcg/optimize: Split out finish_folding, Richard Henderson, 2021/10/29
- [PULL v2 16/60] tcg/optimize: Return true from tcg_opt_gen_{mov, movi}, Richard Henderson, 2021/10/29
- [PULL v2 18/60] tcg/optimize: Use a boolean to avoid a mass of continues,
Richard Henderson <=
- [PULL v2 11/60] tcg/optimize: Split out init_arguments, Richard Henderson, 2021/10/29
- [PULL v2 14/60] tcg/optimize: Drop nb_oargs, nb_iargs locals, Richard Henderson, 2021/10/29
- [PULL v2 19/60] tcg/optimize: Split out fold_mb, fold_qemu_{ld,st}, Richard Henderson, 2021/10/29
- [PULL v2 22/60] tcg/optimize: Split out fold_brcond2, Richard Henderson, 2021/10/29
- [PULL v2 20/60] tcg/optimize: Split out fold_const{1,2}, Richard Henderson, 2021/10/29
- [PULL v2 25/60] tcg/optimize: Split out fold_mulu2_i32, Richard Henderson, 2021/10/29
- [PULL v2 21/60] tcg/optimize: Split out fold_setcond2, Richard Henderson, 2021/10/29
- [PULL v2 24/60] tcg/optimize: Split out fold_setcond, Richard Henderson, 2021/10/29
- [PULL v2 26/60] tcg/optimize: Split out fold_addsub2_i32, Richard Henderson, 2021/10/29
- [PULL v2 27/60] tcg/optimize: Split out fold_movcond, Richard Henderson, 2021/10/29