[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 16/67] target/arm: Fixup comment re handle_cpu_signal
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v5 16/67] target/arm: Fixup comment re handle_cpu_signal |
Date: |
Sat, 30 Oct 2021 01:27:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/15/21 06:10, Richard Henderson wrote:
> The named function no longer exists.
It seems to be declared inlined since QEMU v0.1.0 in 2003!
So it was likely a typo.
Anyhow,
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Refer to host_signal_handler instead.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/sve_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c
> index dab5f1d1cd..07be55b7e1 100644
> --- a/target/arm/sve_helper.c
> +++ b/target/arm/sve_helper.c
> @@ -6118,7 +6118,7 @@ DO_LDN_2(4, dd, MO_64)
> * linux-user/ in its get_user/put_user macros.
> *
> * TODO: Construct some helpers, written in assembly, that interact with
> - * handle_cpu_signal to produce memory ops which can properly report errors
> + * host_signal_handler to produce memory ops which can properly report errors
> * without racing.
> */
>
>
- [PATCH v5 08/67] linux-user/host/ppc: Populate host_signal.h, (continued)
- [PATCH v5 08/67] linux-user/host/ppc: Populate host_signal.h, Richard Henderson, 2021/10/15
- [PATCH v5 09/67] linux-user/host/alpha: Populate host_signal.h, Richard Henderson, 2021/10/15
- [PATCH v5 12/67] linux-user/host/aarch64: Populate host_signal.h, Richard Henderson, 2021/10/15
- [PATCH v5 13/67] linux-user/host/s390: Populate host_signal.h, Richard Henderson, 2021/10/15
- [PATCH v5 15/67] linux-user/host/riscv: Populate host_signal.h, Richard Henderson, 2021/10/15
- [PATCH v5 16/67] target/arm: Fixup comment re handle_cpu_signal, Richard Henderson, 2021/10/15
- [PATCH v5 20/67] linux-user: Add cpu_loop_exit_sigsegv, Richard Henderson, 2021/10/15
- [PATCH v5 11/67] linux-user/host/arm: Populate host_signal.h, Richard Henderson, 2021/10/15
- [PATCH v5 17/67] linux-user/host/riscv: Improve host_signal_write, Richard Henderson, 2021/10/15
- [PATCH v5 14/67] linux-user/host/mips: Populate host_signal.h, Richard Henderson, 2021/10/15
- [PATCH v5 19/67] hw/core: Add TCGCPUOps.record_sigsegv, Richard Henderson, 2021/10/15
- [PATCH v5 21/67] target/alpha: Implement alpha_cpu_record_sigsegv, Richard Henderson, 2021/10/15
- [PATCH v5 24/67] target/cris: Make cris_cpu_tlb_fill sysemu only, Richard Henderson, 2021/10/15
- [PATCH v5 18/67] linux-user/signal: Drop HOST_SIGNAL_PLACEHOLDER, Richard Henderson, 2021/10/15