Re: [RFC PATCH v5 01/26] util: Make some iova_tree parameters const

[Eugenio Perez Martin]

On Sun, Oct 31, 2021 at 7:59 PM Juan Quintela <quintela@redhat.com> wrote:
>
> Eugenio Pérez <eperezma@redhat.com> wrote:
> > As qemu guidelines:
> > Unless a pointer is used to modify the pointed-to storage, give it the
> > "const" attribute.
> >
> > In the particular case of iova_tree_find it allows to enforce what is
> > requested by its comment, since the compiler would shout in case of
> > modifying or freeing the const-qualified returned pointer.
> >
> > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > Acked-by: Peter Xu <peterx@redhat.com>
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> This patch can go in already, whose tree should this go through?
>

Hi Juan,

Sorry for being unclear, this patch has been already queued in
Bonzini's tree [1]. I included it here because it is still not in the
master branch.

Thanks!

[1] https://lists.nongnu.org/archive/html/qemu-devel/2021-10/msg03407.html

> Later, Juan.
>