qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 23/66] target/arm: Implement arm_cpu_record_sigsegv


From: Richard Henderson
Subject: Re: [PATCH v6 23/66] target/arm: Implement arm_cpu_record_sigsegv
Date: Mon, 1 Nov 2021 13:30:35 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 11/1/21 1:25 PM, Peter Maydell wrote:
On Mon, 1 Nov 2021 at 17:09, Richard Henderson
<richard.henderson@linaro.org> wrote:

On 11/1/21 12:30 PM, Peter Maydell wrote:
We seem to be restricting tlb_fill to sysemu already.

Not true:

-#endif /* !defined(CONFIG_USER_ONLY) */
-
  bool arm_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
                        MMUAccessType access_type, int mmu_idx,
                        bool probe, uintptr_t retaddr)
  {
      ARMCPU *cpu = ARM_CPU(cs);
      ARMMMUFaultInfo fi = {};
-
-#ifdef CONFIG_USER_ONLY

Yes, that's restricting tlb_fill to sysemu only now (in this patch),
not "later", right ?

Oh, I see what you mean, re

   "... and we'll be able to restrict
    the tlb_fill hook to sysemu later."

This was in reference to patch 41, "accel/tcg: Restrict TCGCPUOps::tlb_fill() to sysemu", where I remove the tlb_fill hook from TCGCPUOps for CONFIG_USER_ONLY.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]