[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 58/60] accel/tcg: Report unaligned load/store for user-only
From: |
Richard Henderson |
Subject: |
[PATCH v7 58/60] accel/tcg: Report unaligned load/store for user-only |
Date: |
Mon, 1 Nov 2021 13:27:27 -0400 |
Use the new cpu_loop_exit_sigbus for cpu_mmu_lookup.
Reviewed-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/user-exec.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
index 1ee64f01fc..aaf47d89d2 100644
--- a/accel/tcg/user-exec.c
+++ b/accel/tcg/user-exec.c
@@ -218,9 +218,14 @@ static void validate_memop(MemOpIdx oi, MemOp expected)
static void *cpu_mmu_lookup(CPUArchState *env, target_ulong addr,
MemOpIdx oi, uintptr_t ra, MMUAccessType type)
{
+ MemOp mop = get_memop(oi);
+ int a_bits = get_alignment_bits(mop);
void *ret;
- /* TODO: Enforce guest required alignment. */
+ /* Enforce guest required alignment. */
+ if (unlikely(addr & ((1 << a_bits) - 1))) {
+ cpu_loop_exit_sigbus(env_cpu(env), addr, type, ra);
+ }
ret = g2h(env_cpu(env), addr);
set_helper_retaddr(ra);
--
2.25.1
- [PATCH v7 48/60] target/ppc: Move SPR_DSISR setting to powerpc_excp, (continued)
- [PATCH v7 48/60] target/ppc: Move SPR_DSISR setting to powerpc_excp, Richard Henderson, 2021/11/01
- [PATCH v7 50/60] target/ppc: Restrict ppc_cpu_do_unaligned_access to sysemu, Richard Henderson, 2021/11/01
- [PATCH v7 41/60] accel/tcg: Restrict TCGCPUOps::tlb_fill() to sysemu, Richard Henderson, 2021/11/01
- [PATCH v7 43/60] linux-user: Add cpu_loop_exit_sigbus, Richard Henderson, 2021/11/01
- [PATCH v7 51/60] linux-user/ppc: Remove POWERPC_EXCP_ALIGN handling, Richard Henderson, 2021/11/01
- [PATCH v7 46/60] linux-user/hppa: Remove EXCP_UNALIGN handling, Richard Henderson, 2021/11/01
- [PATCH v7 49/60] target/ppc: Set fault address in ppc_cpu_do_unaligned_access, Richard Henderson, 2021/11/01
- [PATCH v7 56/60] target/sparc: Set fault address in sparc_cpu_do_unaligned_access, Richard Henderson, 2021/11/01
- [PATCH v7 54/60] target/sparc: Remove DEBUG_UNALIGNED, Richard Henderson, 2021/11/01
- [PATCH v7 57/60] accel/tcg: Report unaligned atomics for user-only, Richard Henderson, 2021/11/01
- [PATCH v7 58/60] accel/tcg: Report unaligned load/store for user-only,
Richard Henderson <=
- [PATCH v7 52/60] target/s390x: Implement s390x_cpu_record_sigbus, Richard Henderson, 2021/11/01
- [PATCH v7 59/60] tcg: Add helper_unaligned_{ld, st} for user-only sigbus, Richard Henderson, 2021/11/01
- [PATCH v7 55/60] target/sparc: Split out build_sfsr, Richard Henderson, 2021/11/01
- [PATCH v7 53/60] target/sh4: Set fault address in superh_cpu_do_unaligned_access, Richard Henderson, 2021/11/01
- [PATCH v7 60/60] linux-user: Handle BUS_ADRALN in host_signal_handler, Richard Henderson, 2021/11/01