Re: [PATCH v3 00/32] target/mips: Fully convert MSA opcodes to decodetree

[Philippe Mathieu-Daudé]

On 10/28/21 23:08, Philippe Mathieu-Daudé wrote:

> This series converts 2000+ lines of switch() code to decodetree
> description, so this hard-to-review/modify switch is auto generated
> by the decodetree script. This is a big win for maintenance (and
> indeed the convertion revealed 2 bugs).

> Philippe Mathieu-Daudé (32):
>   target/mips: Fix MSA MADDV.B opcode
>   target/mips: Fix MSA MSUBV.B opcode
>   tests/tcg/mips: Run MSA opcodes tests on user-mode emulation

All patches except #3 (the user-mode tests) queued to mips-next.

>   target/mips: Use dup_const() to simplify
>   target/mips: Have check_msa_access() return a boolean
>   target/mips: Use enum definitions from CPUMIPSMSADataFormat enum
>   target/mips: Rename sa16 -> sa, bz_df -> bz -> bz_v
>   target/mips: Convert MSA LDI opcode to decodetree
>   target/mips: Convert MSA I5 instruction format to decodetree
>   target/mips: Convert MSA BIT instruction format to decodetree
>   target/mips: Convert MSA SHF opcode to decodetree
>   target/mips: Convert MSA I8 instruction format to decodetree
>   target/mips: Convert MSA load/store instruction format to decodetree
>   target/mips: Convert MSA 2RF instruction format to decodetree
>   target/mips: Convert MSA FILL opcode to decodetree
>   target/mips: Convert MSA 2R instruction format to decodetree
>   target/mips: Convert MSA VEC instruction format to decodetree
>   target/mips: Convert MSA 3RF instruction format to decodetree
>     (DF_HALF)
>   target/mips: Convert MSA 3RF instruction format to decodetree
>     (DF_WORD)
>   target/mips: Convert MSA 3R instruction format to decodetree (part
>     1/4)
>   target/mips: Convert MSA 3R instruction format to decodetree (part
>     2/4)
>   target/mips: Convert MSA 3R instruction format to decodetree (part
>     3/4)
>   target/mips: Convert MSA 3R instruction format to decodetree (part
>     4/4)
>   target/mips: Convert MSA ELM instruction format to decodetree
>   target/mips: Convert MSA COPY_U opcode to decodetree
>   target/mips: Convert MSA COPY_S and INSERT opcodes to decodetree
>   target/mips: Convert MSA MOVE.V opcode to decodetree
>   target/mips: Convert CFCMSA opcode to decodetree
>   target/mips: Convert CTCMSA opcode to decodetree
>   target/mips: Remove generic MSA opcode
>   target/mips: Remove one MSA unnecessary decodetree overlap group
>   target/mips: Adjust style in msa_translate_init()