[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vhost-vdpa: fix memory leak in vhost_vdpa_get_max_queue_pair
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] vhost-vdpa: fix memory leak in vhost_vdpa_get_max_queue_pairs() |
|
Date: |
Tue, 2 Nov 2021 18:51:36 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 11/2/21 17:39, Stefan Hajnoczi wrote:
> Reported by Coverity (CID 1465228).
>
> Fixes: 402378407dbdce79ce745a13f5c84815f929cfdd ("vhost-vdpa: multiqueue
> support")
> Cc: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> net/vhost-vdpa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index 49ab322511..373b706b90 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -214,7 +214,7 @@ static NetClientState *net_vhost_vdpa_init(NetClientState
> *peer,
> static int vhost_vdpa_get_max_queue_pairs(int fd, int *has_cvq, Error **errp)
> {
> unsigned long config_size = offsetof(struct vhost_vdpa_config, buf);
> - struct vhost_vdpa_config *config;
> + g_autofree struct vhost_vdpa_config *config = NULL;
> __virtio16 *max_queue_pairs;
> uint64_t features;
> int ret;
>
Stefano sent the same fix few minutes before you ;)
20211102155157.241034-1-sgarzare@redhat.com/">https://lore.kernel.org/qemu-devel/20211102155157.241034-1-sgarzare@redhat.com/