Re: [PATCH v4 5/5] block: Deprecate transaction type drive-backup

[Vladimir Sementsov-Ogievskiy]

25.10.2021 07:24, Markus Armbruster wrote:
> Several moons ago, Vladimir posted
>
>      Subject: [PATCH v2 3/3] qapi: deprecate drive-backup
>      Date: Wed,  5 May 2021 16:58:03 +0300
>      Message-Id:<20210505135803.67896-4-vsementsov@virtuozzo.com>
>      https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg01394.html
>
> with this
>
>      TODO: We also need to deprecate drive-backup transaction action..
>      But union members in QAPI doesn't support 'deprecated' feature. I tried
>      to dig a bit, but failed :/ Markus, could you please help with it? At
>      least by advice?
>
> This is one way to resolve it.  Sorry it took so long.
>
> John explored another way, namely adding feature flags to union
> branches.  Could also be useful, say to add different features to
> branches in multiple unions sharing the same tag enum.
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

(with simplified commit message of course :)

--
Best regards,
Vladimir