Re: [PATCH v3 05/25] target/ppc: Implement Vector Insert from GPR using GPR index insns

[Richard Henderson]

On 11/4/21 8:36 AM, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst<matheus.ferst@eldorado.org.br>
>
> Implements the following PowerISA v3.1 instructions:
> vinsblx: Vector Insert Byte from GPR using GPR-specified Left-Index
> vinshlx: Vector Insert Halfword from GPR using GPR-specified Left-Index
> vinswlx: Vector Insert Word from GPR using GPR-specified Left-Index
> vinsdlx: Vector Insert Doubleword from GPR using GPR-specified
>           Left-Index
> vinsbrx: Vector Insert Byte from GPR using GPR-specified Right-Index
> vinshrx: Vector Insert Halfword from GPR using GPR-specified
>           Right-Index
> vinswrx: Vector Insert Word from GPR using GPR-specified Right-Index
> vinsdrx: Vector Insert Doubleword from GPR using GPR-specified
>           Right-Index
>
> The helpers and do_vinsx receive i64 to allow code sharing with the
> future implementation of Vector Insert from VSR using GPR Index.
>
> Signed-off-by: Matheus Ferst<matheus.ferst@eldorado.org.br>
> ---
> v3:
> - Fixed helper endianness issue
> ---
>   target/ppc/helper.h                 |  4 +++
>   target/ppc/insn32.decode            |  9 ++++++
>   target/ppc/int_helper.c             | 30 +++++++++++++++++
>   target/ppc/translate/vmx-impl.c.inc | 50 +++++++++++++++++++++++++++++
>   4 files changed, 93 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~