Re: [PATCH v7 2/2] migration/dirtyrate: implement dirty-bitmap dirtyrate calculation

[Eric Blake]

On Tue, Jul 20, 2021 at 11:19:17PM +0800, huangy81@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> 
> introduce dirty-bitmap mode as the third method of calc-dirty-rate.
> implement dirty-bitmap dirtyrate calculation, which can be used
> to measuring dirtyrate in the absence of dirty-ring.
> 
> introduce "dirty_bitmap:-b" option in hmp calc_dirty_rate to
> indicate dirty bitmap method should be used for calculation.
> 
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---

> +++ b/qapi/migration.json
> @@ -1747,13 +1747,15 @@
>  #
>  # @page-sampling: calculate dirtyrate by sampling pages.
>  #
> -# @dirty-ring: calculate dirtyrate by via dirty ring.
> +# @dirty-ring: calculate dirtyrate by dirty ring.
> +#
> +# @dirty-bitmap: calculate dirtyrate by dirty bitmap.

Missing a '(since 6.2)' tag.

>  #
>  # Since: 6.1
>  #
>  ##
>  { 'enum': 'DirtyRateMeasureMode',
> -  'data': ['page-sampling', 'dirty-ring'] }
> +  'data': ['page-sampling', 'dirty-ring', 'dirty-bitmap'] }
>  

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org