[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 07/36] bsd-user/i386: Move the inlines into signal.c

From: Warner Losh
Subject: Re: [PATCH v4 07/36] bsd-user/i386: Move the inlines into signal.c
Date: Fri, 5 Nov 2021 10:55:49 -0600

On Fri, Nov 5, 2021 at 10:45 AM Warner Losh <imp@bsdimp.com> wrote:

On Fri, Nov 5, 2021 at 10:21 AM Richard Henderson <richard.henderson@linaro.org> wrote:
On 11/4/21 11:18 PM, Warner Losh wrote:
> +abi_long set_sigtramp_args(CPUX86State *env, int sig,
> +                           struct target_sigframe *frame,
> +                           abi_ulong frame_addr,
> +                           struct target_sigaction *ka);
> +abi_long get_mcontext(CPUX86State *regs, target_mcontext_t *mcp, int flags);
> +abi_long set_mcontext(CPUX86State *regs, target_mcontext_t *mcp, int srflag);
> +abi_long get_ucontext_sigreturn(CPUX86State *regs, abi_ulong target_sf,
> +                                abi_ulong *target_uc);
>   #endif /* TARGET_ARCH_SIGNAL_H */

You should use the CPUArchState typedef, instead of CPUX86State directly, and place these
declarations in a shared header.

Will do! Thanks!

FYI: I'm going to add a change that moves this to target_os_ucommon.h after I've
made i386 and x86_64 use the functions. That way all revisions will still compile
and I don't have to deal with the 'half-way' state. I'll then tweak the arm commits
later in the series to not add them arm specific prototypes to the target_arch_signal.h

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]