[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] trace-events,pci: unify trace events format
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] trace-events,pci: unify trace events format |
|
Date: |
Fri, 5 Nov 2021 20:28:35 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 11/5/21 20:25, Laurent Vivier wrote:
> Unify format used by trace_pci_update_mappings_del(),
> trace_pci_update_mappings_add(), trace_pci_cfg_write() and
> trace_pci_cfg_read() to print the device name and bus number,
> slot number and function number.
>
> For instance:
>
> pci_cfg_read virtio-net-pci 00:0 @0x20 -> 0xffffc00c
> pci_cfg_write virtio-net-pci 00:0 @0x20 <- 0xfea0000c
> pci_update_mappings_del d=0x555810b92330 01:00.0 4,0xffffc000+0x4000
> pci_update_mappings_add d=0x555810b92330 01:00.0 4,0xfea00000+0x4000
>
> becomes
>
> pci_cfg_read virtio-net-pci 01:00.0 @0x20 -> 0xffffc00c
> pci_cfg_write virtio-net-pci 01:00.0 @0x20 <- 0xfea0000c
> pci_update_mappings_del virtio-net-pci 01:00.0 4,0xffffc000+0x4000
> pci_update_mappings_add virtio-net-pci 01:00.0 4,0xfea00000+0x4000
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> hw/pci/pci.c | 4 ++--
> hw/pci/pci_host.c | 6 ++++--
> hw/pci/trace-events | 8 ++++----
> 3 files changed, 10 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>